All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Philip Oakley" <philipoakley@iee.org>
Cc: "Jeff King" <peff@peff.net>, "René Scharfe" <l.s.r@web.de>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] use child_process_init() to initialize struct child_process variables
Date: Mon, 03 Nov 2014 10:26:48 -0800	[thread overview]
Message-ID: <xmqqmw88rvh3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <F44397C122BB4E63B89EC9BE26007B2E@PhilipOakley> (Philip Oakley's message of "Sun, 2 Nov 2014 22:54:57 -0000")

"Philip Oakley" <philipoakley@iee.org> writes:

> This certainly looks the way to go. The one extra question would be
> whether the symref should be included by default when HEAD is present,
> or only if there was possible ambiguity between the other listed
> refs.

Just include the "\0symref=..." for any symbolic ref you mention,
and the ref in question does not even have to be "HEAD", I would
say.

The mechanism chosen should be something that will be transparently
ignored by existing implementations, there is no need to make the
data format conditional.  If the new implementations of the reading
side want to make a choice between following the new "\0symref=..."
and ignoring it and use the traditional heuristics for some
unknown/unanticipated reason, that should be the choice for the
readers, not for the writers.

  reply	other threads:[~2014-11-03 18:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 20:52 [PATCH] use child_process_init() to initialize struct child_process variables René Scharfe
2014-10-28 21:58 ` mike.gorchak.qnx
2014-10-29 17:21 ` Jeff King
2014-10-29 19:16   ` Junio C Hamano
2014-10-30 18:07     ` Junio C Hamano
2014-10-30 21:25       ` Jeff King
2014-10-30 18:08     ` [PATCH] bundle: split out a helper function to compute and write prerequisites Junio C Hamano
2014-10-30 21:26       ` Jeff King
2014-10-30 21:35     ` [PATCH] use child_process_init() to initialize struct child_process variables Jeff King
2014-10-31  0:19       ` Philip Oakley
2014-10-31 21:48         ` Junio C Hamano
2014-11-01  3:33           ` Jeff King
2014-11-02 22:54             ` Philip Oakley
2014-11-03 18:26               ` Junio C Hamano [this message]
2014-11-03 22:04                 ` Jeff King
2014-11-03 23:42                   ` Junio C Hamano
2014-11-04 21:56                     ` Junio C Hamano
2014-11-04 23:32                       ` Jeff King
2014-11-05  0:32                         ` Junio C Hamano
2014-11-05 13:41                         ` Philip Oakley
2014-11-05 13:35                     ` Philip Oakley
2014-11-05 19:35                       ` Jeff King
2014-11-05 23:50                         ` Philip Oakley
2014-11-09 13:49   ` René Scharfe
2014-11-10  7:14     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmw88rvh3.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    --cc=philipoakley@iee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.