From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] t0026: Add missing &&
Date: Mon, 25 Aug 2014 10:38:23 -0700 [thread overview]
Message-ID: <xmqqmwasmpv4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53F797B3.3070107@web.de> ("Torsten Bögershausen"'s message of "Fri, 22 Aug 2014 21:19:15 +0200")
Torsten Bögershausen <tboegi@web.de> writes:
> Fix the broken && chain
>
> Reported-By: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
Please fold this kind of "oops fix breakages discovered in the
version that hasn't been reached 'next'" to the patch that
introduces the breakage, with "Helped-by: whom".
Thanks.
> t/t0026-eol-config.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh
> index 43a580a..4806969 100755
> --- a/t/t0026-eol-config.sh
> +++ b/t/t0026-eol-config.sh
> @@ -84,9 +84,9 @@ test_expect_success NATIVE_CRLF 'eol native is crlf' '
>
> rm -rf native_eol && mkdir native_eol &&
> ( cd native_eol &&
> - printf "*.txt text\n" > .gitattributes
> - printf "one\r\ntwo\r\nthree\r\n" > filedos.txt
> - printf "one\ntwo\nthree\n" > fileunix.txt
> + printf "*.txt text\n" > .gitattributes &&
> + printf "one\r\ntwo\r\nthree\r\n" > filedos.txt &&
> + printf "one\ntwo\nthree\n" > fileunix.txt &&
> git init &&
> git config core.autocrlf false &&
> git config core.eol native &&
prev parent reply other threads:[~2014-08-25 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:19 [PATCH v2 3/3] t0026: Add missing && Torsten Bögershausen
2014-08-25 17:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwasmpv4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.