All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Mar 2014, #07; Fri, 28)
Date: Mon, 31 Mar 2014 15:04:55 -0700	[thread overview]
Message-ID: <xmqqmwg62feg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: CACsJy8CucWgHWjwpq+=wD1KQuTNpx2sokhQtFY02Puy-FFJi4w@mail.gmail.com

Duy Nguyen <pclouds@gmail.com> writes:

> On Sat, Mar 29, 2014 at 5:21 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> * nd/gc-aggressive (2014-03-17) 4 commits
>>  - gc --aggressive: three phase repacking
>>  - gc --aggressive: make --depth configurable
>>  - pack-objects: support --keep
>>  - environment.c: fix constness for odb_pack_keep()
>
> Using --before=1.year.ago my way does not keep all recent chains short
> because commit time is unreliable. But even with better recent object
> selection, the performance gain is still within noise level. I suggest
> we keep " gc --aggressive: make --depth configurable" and drop the
> rest.

I think the three-phase thing may not be so well conceived or
cooked, but the other three looked like reasonable changes, although
it would have been easier to say so if "pack-objects --keep" were
done without a new buffer of size PATH_MAX ;-)

Let's do the const and --depth and discard the other two.

      reply	other threads:[~2014-03-31 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 22:21 What's cooking in git.git (Mar 2014, #07; Fri, 28) Junio C Hamano
2014-03-28 23:23 ` Michael Haggerty
2014-03-30  7:51   ` Junio C Hamano
2014-03-31 17:56   ` Ronnie Sahlberg
2014-03-31 20:22     ` Michael Haggerty
2014-03-29 15:44 ` Max Horn
2014-03-30  2:01 ` Duy Nguyen
2014-03-31 22:04   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmwg62feg.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.