From: Junio C Hamano <gitster@pobox.com>
To: Sandy Carter <sandy.carter@savoirfairelinux.com>
Cc: git@vger.kernel.org, pclouds@gmail.com
Subject: Re: [PATCH v2] status merge: guarentee space between msg and path
Date: Wed, 12 Mar 2014 12:28:07 -0700 [thread overview]
Message-ID: <xmqqmwgvkyig.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1394580211-13383-1-git-send-email-sandy.carter@savoirfairelinux.com> (Sandy Carter's message of "Tue, 11 Mar 2014 19:23:31 -0400")
Sandy Carter <sandy.carter@savoirfairelinux.com> writes:
> Add space between how and one when printing status of unmerged data.
> This fixes an appending of the how message when it is longer than 20,
> such is the case in some translations such as the french one where the
> colon gets appended to the file:
> supprimé par nous :wt-status.c
> modifié des deux côtés :wt-status.h
> Additionally, having a space makes the file in question easier to select
> in console to quickly address the problem. Without the space, the colon
> (and, sometimes the last word) of the message is selected along with the
> file.
>
> The previous french example should now print as, which is more proper:
> supprimé par nous : wt-status.c
> modifié des deux côtés : wt-status.h
>
> try 2:
> Add function so wt_status_print_unmerged_data() and
> wt_status_print_change_data() make use of the same padding technique
> defined as wt_status_status_padding_string()
>
> This has the additionnal advantage of aligning unmerged paths with paths
> of regular statuses.
>
> Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
> ---
> t/t7060-wtstatus.sh | 16 +++----
> t/t7506-status-submodule.sh | 18 ++++----
> t/t7508-status.sh | 94 +++++++++++++++++++--------------------
> t/t7512-status-help.sh | 30 ++++++-------
This is too noisy a patch to be reviewed. I tried to resurrect
Jonathan's fix from Dec 2013 and posted it elsewhere---does it work
for you?
next prev parent reply other threads:[~2014-03-12 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 16:30 [PATCH] status merge: guarentee space between msg and path Sandy Carter
2014-03-11 19:59 ` Junio C Hamano
2014-03-11 20:22 ` Sandy Carter
2014-03-11 20:26 ` Junio C Hamano
2014-03-11 23:33 ` Duy Nguyen
2014-03-12 18:39 ` Junio C Hamano
2014-03-11 23:23 ` [PATCH v2] " Sandy Carter
2014-03-12 19:28 ` Junio C Hamano [this message]
2014-03-12 20:08 ` Sandy Carter
2014-03-12 20:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwgvkyig.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sandy.carter@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.