From: Junio C Hamano <gitster@pobox.com>
To: Laveesh Bansal <laveeshb@laveeshbansal.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Karthik Nayak <karthik.188@gmail.com>,
Sven Weiland <sven.weiland@tngtech.com>
Subject: Re: [PATCH] builtin/reflog: say "would prune" for named refs with --dry-run
Date: Sun, 25 Oct 2026 18:16:21 -0700 [thread overview]
Message-ID: <xmqqo6chw9ay.fsf@gitster.g> (raw)
In-Reply-To: <20261025191559.79141-1-laveeshb@laveeshbansal.com> (Laveesh Bansal's message of "Sun, 25 Oct 2026 12:15:59 -0700")
Laveesh Bansal <laveeshb@laveeshbansal.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> That will help prevent a similar bug from ever happening again, as
>> there would be only a single place that sets up how the expiration
>> is called, instead of two we currently have.
>
> Agreed, and I think the consolidation is doable.
>
> I suggest keeping this patch as it is, since it fixes the reported
> bug. I'll look into what you describe as a separate patch after this
> one, and the tests added here would stay useful for that patch too.
Sounds like a good plan to me.
next prev parent reply other threads:[~2026-10-26 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 1:38 [PATCH] builtin/reflog: say "would prune" for named refs with --dry-run Laveesh Bansal
2026-10-25 18:07 ` Junio C Hamano
2026-10-25 19:15 ` Laveesh Bansal
2026-10-26 1:16 ` Junio C Hamano [this message]
2026-10-29 12:18 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6chw9ay.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=laveeshb@laveeshbansal.com \
--cc=ps@pks.im \
--cc=sven.weiland@tngtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.