Re: [PATCH v3 0/7] stash creation: avoid unecessary index loads and refreshes

[Junio C Hamano <gitster@pobox.com>]

Phillip Wood <phillip.wood123@gmail.com> writes:

> "git stash push" and "git stash create" load and refresh the index
> multiple times when they only need to do it once. This series removes
> a number of calls to repo_read_preload_index() and refresh_index()
> which reduces the number of lstat() calls on each changed path by
> four for "git stash create" and eight for "git stash push". It also
> removes a duplicate call to check_changes() so that when stashing
> untracked files we only walk them once.
>
> Changes since V1:
>  - Added an enum for the various return values from do_create_stash()
>  - Fixed typos in the commit message of patch 2 (was patch 1)
>  - Removed an unnecessary index refresh and several unnecessary index
>    preloads

Nicely split and described.  Looked quite well done.

Will queue.

Thanks.