All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Aaron Plattner <aplattner@nvidia.com>
Cc: git@vger.kernel.org,  Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [PATCH] http: preserve wwwauth_headers across redirects
Date: Tue, 07 Jul 2026 12:16:58 -0700	[thread overview]
Message-ID: <xmqqo6gi3905.fsf@gitster.g> (raw)
In-Reply-To: <5144a29d-a53f-4446-beff-e1f549345bf9@nvidia.com> (Aaron Plattner's message of "Tue, 2 Jun 2026 17:37:48 -0700")

Aaron Plattner <aplattner@nvidia.com> writes:

>> I wonder if it would make the design more robust and future-proof to
>> encapsulate this logic in credential.c instead.  For example, we
>> could introduce a helper function:
>> 
>>      void credential_update_url(struct credential *c, const char *url)
>> 
>> that does what the new code added around credential_from_url() by
>> this patch does, perhaps?
>
> Yeah, maybe. I'll think about this design some more.

Sorry, I lost track.

Did anything come of that discussion?  No rush, since this change
fixes an immediate issue and the helper suggestion is for long-term
future-proofing.  We can treat them as separate steps.

Thanks. 

  reply	other threads:[~2026-07-07 19:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 16:11 [PATCH] http: preserve wwwauth_headers across redirects Aaron Plattner
2026-06-03  0:15 ` Junio C Hamano
2026-06-03  0:37   ` Aaron Plattner
2026-07-07 19:16     ` Junio C Hamano [this message]
2026-07-07 19:21       ` Aaron Plattner
2026-07-07 22:35         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo6gi3905.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aplattner@nvidia.com \
    --cc=git@vger.kernel.org \
    --cc=rrameshbabu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.