From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Tian Yuchen <a3205153416@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4] setup: allow cwd/.git to be a symlink to a directory
Date: Tue, 17 Feb 2026 13:10:57 -0800 [thread overview]
Message-ID: <xmqqo6ln9iu6.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZR-0DGm4eHB6oqi6FpdOV1YDT6mf0=ONZnpi==3o3ab+w@mail.gmail.com> (Karthik Nayak's message of "Tue, 17 Feb 2026 10:56:03 -0800")
Karthik Nayak <karthik.188@gmail.com> writes:
> My indication wasn't separate the tests out into an individual commit.
> But rather to highlight that this one commit is doing multiple things
> and it would be nice to split it out and each commit could tackle an
> individual problem with tests included.
Like treating "all stat failures silently ignored, instead of
treating ENOENT specifically" and "a non-directory non-file
filesystem entity being silently ignored" two separate issues, so at
least two patches, and possibly if we need a preliminary clean-up
to make these two changes, yet another one? And each patch focuses
on one thing it addresses, with its own test? That makes sense.
Thanks.
next prev parent reply other threads:[~2026-02-17 21:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 18:21 [RFC] setup: fail if .git is not a file or directory Tian Yuchen
2026-02-11 19:47 ` Junio C Hamano
2026-02-12 17:33 ` Tian Yuchen
2026-02-12 17:24 ` [PATCH v2] " Tian Yuchen
2026-02-12 20:59 ` Junio C Hamano
2026-02-13 16:37 ` Tian Yuchen
2026-02-14 4:52 ` [PATCH v3] " Tian Yuchen
2026-02-15 8:41 ` Junio C Hamano
2026-02-15 16:22 ` Tian Yuchen
2026-02-16 2:37 ` Junio C Hamano
2026-02-16 16:02 ` Tian Yuchen
2026-02-17 8:41 ` [PATCH v4] setup: allow cwd/.git to be a symlink to a directory Tian Yuchen
2026-02-17 11:26 ` Karthik Nayak
2026-02-17 15:30 ` Tian Yuchen
2026-02-17 18:56 ` Karthik Nayak
2026-02-17 21:10 ` Junio C Hamano [this message]
2026-02-17 17:01 ` Junio C Hamano
2026-02-17 18:50 ` Karthik Nayak
2026-02-18 4:08 ` Tian Yuchen
2026-02-17 17:59 ` Karthik Nayak
2026-02-18 5:18 ` [PATCH v5 0/2] setup.c: v5 reroll Tian Yuchen
2026-02-18 5:18 ` [PATCH v5 1/2] setup: distingush ENOENT from other stat errors Tian Yuchen
2026-02-18 10:12 ` Karthik Nayak
2026-02-18 11:11 ` Tian Yuchen
2026-02-18 18:15 ` Junio C Hamano
2026-02-18 18:43 ` Junio C Hamano
2026-02-18 5:18 ` [PATCH v5 2/2] setup: allow cwd/.git to be a symlink to a directory Tian Yuchen
2026-02-18 10:27 ` Karthik Nayak
2026-02-18 11:20 ` Tian Yuchen
2026-02-18 18:25 ` Junio C Hamano
2026-02-19 5:11 ` Tian Yuchen
2026-02-15 17:08 ` [PATCH v3] setup: fail if .git is not a file or directory Tian Yuchen
2026-02-12 22:39 ` [RFC] " brian m. carlson
2026-02-12 22:45 ` Junio C Hamano
2026-02-12 23:03 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6ln9iu6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=a3205153416@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.