All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Wiktor Mis via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Wiktor Mis <mwiktor023@gmail.com>
Subject: Re: [PATCH v2] completion: complete "git -<TAB>" with short options
Date: Thu, 27 Nov 2025 13:59:22 -0800	[thread overview]
Message-ID: <xmqqo6onjfwl.fsf@gitster.g> (raw)
In-Reply-To: <aSf+yrfJo8dRIkSo@szeder.dev> ("SZEDER Gábor"'s message of "Thu, 27 Nov 2025 08:33:30 +0100")

SZEDER Gábor <szeder.dev@gmail.com> writes:

> know what those short options are good for.  E.g. I just learned from
> this patch that the main git command accepts -p and -P options, but I
> have no idea what they are doing.)
>
> So overall I'm somewhat negative on this patch and in general on the
> direction it takes us, but if we do want to go in this direction, then
> it will definitely need more justification than this.

Ah, yes, I totally forgot earlier discussions we had long ago, e.g.,

  https://lore.kernel.org/git/20070205024704.GB12917@spearce.org/

Completing potential values for a single letter short option is one
thihng, but completing single letter short options themselves,
unless the completion script can offer a short-help somehow, e.g.,

    $ git -<TAB><TAB>
    -C (chdir there before running the command)
    -p (enable pager)
    ...

I agree that it would not be of much use.

  reply	other threads:[~2025-11-27 21:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25  6:38 [PATCH] Add completion for short options Wiktor Mis via GitGitGadget
2025-11-25 16:42 ` Junio C Hamano
2025-11-26 16:26 ` [PATCH v2] completion: complete "git -<TAB>" with " Wiktor Mis via GitGitGadget
2025-11-26 20:09   ` Junio C Hamano
2025-11-27  7:33     ` SZEDER Gábor
2025-11-27 21:59       ` Junio C Hamano [this message]
2025-12-07  0:38         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo6onjfwl.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=mwiktor023@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.