From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Josh Steadmon <steadmon@google.com>,
git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v2 2/5] libgit-sys: add symlink to git repo root and build out of tree
Date: Mon, 24 Mar 2025 08:42:54 -0700 [thread overview]
Message-ID: <xmqqo6xqo2o1.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQ+05r0iJO3me2=yz1KWaU_S_WQmbeciOqZGxYWgbT8dw@mail.gmail.com> (Eric Sunshine's message of "Sat, 22 Mar 2025 21:46:49 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Fri, Mar 21, 2025 at 6:14 PM Josh Steadmon <steadmon@google.com> wrote:
>> Unlike `cargo build`, `cargo package` does not get access to the entire Git repo
>> containing a Rust crate. Instead, it prepares a directory starting from the
>> crate root (potentially excluding files, such as those not under version
>> control, or explicity excluded in the Cargo.toml file).
>
> s/explicity/explicitly/
>
>> diff --git a/contrib/libgit-sys/git-src b/contrib/libgit-sys/git-src
>> @@ -0,0 +1 @@
>> +../..
>> \ No newline at end of file
>
> Meh.
https://github.com/git/git/actions/runs/14030831429/job/39278185588#step:3:1
All of the Windows test jobs (not build ones) are broken due to the
presence of ../.. symbolic link.
Is that ugly hack the only way we can make this work?
next prev parent reply other threads:[~2025-03-24 15:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 23:24 [RFC PATCH v1 0/4] Fix `cargo package` for libgit-sys Josh Steadmon
2025-03-18 23:24 ` [RFC PATCH v1 1/4] libgitpub: move to separate contrib/ directory Josh Steadmon
2025-03-18 23:24 ` [RFC PATCH v1 2/4] libgit-sys: add symlink to git repo root and clean after build Josh Steadmon
2025-03-19 22:23 ` Josh Steadmon
2025-03-20 11:10 ` Phillip Wood
2025-03-21 19:49 ` Josh Steadmon
2025-03-18 23:24 ` [RFC PATCH v1 3/4] libgit-sys: parallelize build with Cargo's jobserver Josh Steadmon
2025-03-18 23:24 ` [RFC PATCH v1 4/4] libgit-sys: exclude unnecessary directories in git-src Josh Steadmon
2025-03-21 22:14 ` [PATCH v2 0/5] Fix `cargo package` for libgit-sys Josh Steadmon
2025-03-21 22:14 ` [PATCH v2 1/5] libgitpub: move to separate contrib/ directory Josh Steadmon
2025-03-21 22:14 ` [PATCH v2 2/5] libgit-sys: add symlink to git repo root and build out of tree Josh Steadmon
2025-03-23 1:46 ` Eric Sunshine
2025-03-24 15:42 ` Junio C Hamano [this message]
2025-03-25 17:57 ` Josh Steadmon
2025-03-25 23:08 ` Junio C Hamano
2025-03-27 18:58 ` Josh Steadmon
2025-03-29 10:46 ` Junio C Hamano
2025-03-31 14:52 ` Johannes Schindelin
2025-03-21 22:14 ` [PATCH v2 3/5] libgit-sys: parallelize build with Cargo's jobserver Josh Steadmon
2025-03-21 22:14 ` [PATCH v2 4/5] libgit-sys: exclude unnecessary directories in git-src Josh Steadmon
2025-03-21 22:14 ` [PATCH v2 5/5] libgit-{sys,rs}: add license and description fields Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6xqo2o1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=steadmon@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.