All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Samuel Abraham <abrahamadekunle50@gmail.com>
Cc: Samuel Adekunle Abraham via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  ps@pks.im,  phillip.wood@dunelm.org.uk,
	christian.couder@gmail.com
Subject: Re: [PATCH] t7300-clean.sh: use test_path_* helper functions
Date: Tue, 08 Oct 2024 11:13:15 -0700	[thread overview]
Message-ID: <xmqqo73u1n0k.fsf@gitster.g> (raw)
In-Reply-To: <CADYq+fYZSGBTnO+dM+MtHj=oUMqDWt+6wu-wEzwfWQJkSomkWA@mail.gmail.com> (Samuel Abraham's message of "Tue, 8 Oct 2024 09:58:44 +0100")

Samuel Abraham <abrahamadekunle50@gmail.com> writes:

> ...
>  This was the reason for replacing "test ! -[df]" with
> "test_path_is_missing" where I think is appropriate.

Telling that concisely in the proposed log message will help those
who are reviewing the patch and those who are reading "git log -p"
later, and that is what I would want to see after a review exchange
like this.

Thanks.

  reply	other threads:[~2024-10-08 18:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 19:19 [PATCH] t7300-clean.sh: use test_path_* helper functions Samuel Adekunle Abraham via GitGitGadget
2024-10-07 23:01 ` Usman Akinyemi
2024-10-08  1:48 ` Junio C Hamano
2024-10-08  5:12   ` Samuel Abraham
2024-10-08  8:58   ` Samuel Abraham
2024-10-08 18:13     ` Junio C Hamano [this message]
2024-10-09  3:35       ` Samuel Abraham
2024-10-09  7:20         ` Patrick Steinhardt
2024-10-09 15:41           ` Samuel Abraham
2024-10-09 17:31           ` Junio C Hamano
2024-10-08 12:22 ` [PATCH v2] t7300-clean.sh: use test_path_* helper functions for error logging Samuel Adekunle Abraham via GitGitGadget
2024-10-09 17:02   ` [PATCH v3] " Samuel Adekunle Abraham via GitGitGadget
2024-10-09 17:47     ` Junio C Hamano
2024-10-09 18:24       ` Samuel Abraham
2024-10-09 18:22     ` [PATCH v4] " Samuel Adekunle Abraham via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo73u1n0k.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=abrahamadekunle50@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.