From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] transport: fix leak with transport helper URLs
Date: Thu, 08 Aug 2024 09:14:51 -0700 [thread overview]
Message-ID: <xmqqo763j8jo.fsf@gitster.g> (raw)
In-Reply-To: <ZrRV_HrUArsvRgn8@tanuki> (Patrick Steinhardt's message of "Thu, 8 Aug 2024 07:22:04 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> I saw that you've merged this to `next` already, but: this looks good to
>> me, thanks!
>>
>> Patrick
>
> I just noticed that this also makes a couple of test suites pass with
> leak checking enabled. So below diff should likely be applied on top.
I'll think about it. I do not want to see too many "ok, we have now
marked this as leak-free" plus "ouch, we have unrelated fix and its
test now triggers leaks from another subsystem we happen to use",
especially when our primary business is not leak-plugging (e.g., the
"ls-remote outside a repo" use case was a real regression fix even
though it sort of falls into "if it hurts, don't do it" category).
Thanks.
prev parent reply other threads:[~2024-08-08 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 1:11 [PATCH] transport: fix leak with transport helper URLs Junio C Hamano
2024-08-08 4:52 ` Patrick Steinhardt
2024-08-08 5:22 ` Patrick Steinhardt
2024-08-08 16:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo763j8jo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.