From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, newren@gmail.com, vdye@github.com,
rsbecker@nexbridge.com, "Rubén Justo" <rjusto@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH v2] advice: warn when sparse index expands
Date: Mon, 08 Jul 2024 12:34:24 -0700 [thread overview]
Message-ID: <xmqqo777ekzj.fsf@gitster.g> (raw)
In-Reply-To: <pull.1756.v2.git.1720448038745.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Mon, 08 Jul 2024 14:13:58 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> ... This idea has always been in the back of my
> mind since the sparse index was created, but it didn't make sense
> initially when only a few builtins could operate without immediately
> expanding a sparse index to a full one.
Yeah, if this triggered for a command whose operation does require
expanding, then that would be annoying to the users.
The phrasing that suggests "git clean" used in this version does
look better. I wonder if "git clean" would also have to expand and
then trigger this warning, though ;-)
Thanks.
prev parent reply other threads:[~2024-07-08 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 15:14 [PATCH] advice: warn when sparse index expands Derrick Stolee via GitGitGadget
2024-07-03 18:16 ` Junio C Hamano
2024-07-03 19:18 ` Derrick Stolee
2024-07-03 19:28 ` rsbecker
2024-07-03 19:54 ` Junio C Hamano
2024-07-03 20:36 ` Rubén Justo
2024-07-05 20:29 ` Elijah Newren
2024-07-08 12:57 ` Derrick Stolee
2024-07-08 14:13 ` [PATCH v2] " Derrick Stolee via GitGitGadget
2024-07-08 19:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo777ekzj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=rjusto@gmail.com \
--cc=rsbecker@nexbridge.com \
--cc=stolee@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.