From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
Cc: "Dragan Simic" <dsimic@manjaro.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Patrick Steinhardt" <ps@pks.im>,
git@vger.kernel.org, "Drew DeVault" <sir@cmpwn.com>
Subject: Re: [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive
Date: Fri, 19 Apr 2024 08:43:12 -0700 [thread overview]
Message-ID: <xmqqo7a5mk8f.fsf@gitster.g> (raw)
In-Reply-To: <0d584b86-0b48-4e7f-b81c-fdb672dac98b@app.fastmail.com> (Kristoffer Haugsbakk's message of "Fri, 19 Apr 2024 15:43:10 +0200")
"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> On Fri, Apr 19, 2024, at 03:05, Dragan Simic wrote:
>> Fix a bug that allows the "--rfc" and "-k" options to be specified together
>> when "git format-patch" is executed, which was introduced in the commit
>> e0d7db7423a9 ("format-patch: --rfc honors what --subject-prefix sets").
>>
>> Add a couple of additional tests to t4014, to cover additional cases of
>> the mutual exclusivity between different "git format-patch" options.
>>
>> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
>
> Looks good to me FWIW. Also very good description of the changes from
> the previous version to this one.
Yup, very easy to follow what changed and how.
Will queue, thanks all.
next prev parent reply other threads:[~2024-04-19 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 1:05 [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive Dragan Simic
2024-04-19 2:58 ` Dragan Simic
2024-04-19 8:51 ` Drew DeVault
2024-04-19 9:30 ` Dragan Simic
2024-04-19 13:43 ` Kristoffer Haugsbakk
2024-04-19 15:43 ` Junio C Hamano [this message]
2024-04-21 14:00 ` Dragan Simic
2024-04-21 13:50 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7a5mk8f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=sir@cmpwn.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.