From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ignacio Encinas <ignacio@iencinas.com>, git@vger.kernel.org
Subject: Re: [PATCH v3 1/2] t: add a test helper for getting hostname
Date: Tue, 19 Mar 2024 14:00:34 -0700 [thread overview]
Message-ID: <xmqqo7balyx9.fsf@gitster.g> (raw)
In-Reply-To: <20240319205753.GB1159535@coredump.intra.peff.net> (Jeff King's message of "Tue, 19 Mar 2024 16:57:53 -0400")
Jeff King <peff@peff.net> writes:
> I think you need to lose the exit status. Or alternatively do:
>
> hostname=$(test-tool xgethostname || echo unknown)
>
> See my other reply.
As "test-tool xgethostname" runs exactly the same codepath as
"includeIf hostname:blah" feature, I would actually prefer for a
failing "test-tool gethostname" to _break_ this test so that people
can take notice.
next prev parent reply other threads:[~2024-03-19 21:00 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 20:50 [RFC PATCH 0/1] Add hostname condition to includeIf Ignacio Encinas
2024-03-07 20:50 ` [RFC PATCH 1/1] config: learn the "hostname:" includeIf condition Ignacio Encinas
2024-03-07 21:40 ` Junio C Hamano
2024-03-09 10:47 ` Ignacio Encinas Rubio
2024-03-09 17:38 ` Junio C Hamano
2024-03-09 18:18 ` [PATCH v2 0/1] Add hostname condition to includeIf Ignacio Encinas
2024-03-09 18:18 ` [PATCH v2 1/1] config: learn the "hostname:" includeIf condition Ignacio Encinas
2024-03-10 16:59 ` Junio C Hamano
2024-03-10 18:46 ` Ignacio Encinas Rubio
2024-03-11 17:39 ` Junio C Hamano
2024-03-13 21:53 ` Ignacio Encinas Rubio
2024-03-16 6:57 ` Jeff King
2024-03-16 11:19 ` Ignacio Encinas Rubio
2024-03-16 16:00 ` Taylor Blau
2024-03-16 16:46 ` Ignacio Encinas Rubio
2024-03-16 17:02 ` Junio C Hamano
2024-03-16 17:41 ` rsbecker
2024-03-16 18:05 ` Ignacio Encinas Rubio
2024-03-16 18:49 ` rsbecker
2024-03-18 8:17 ` Jeff King
2024-03-16 16:01 ` Taylor Blau
2024-03-16 16:50 ` Ignacio Encinas Rubio
2024-03-19 18:37 ` [PATCH v3 0/2] Add hostname condition to includeIf Ignacio Encinas
2024-03-19 18:37 ` [PATCH v3 1/2] t: add a test helper for getting hostname Ignacio Encinas
2024-03-19 20:31 ` Junio C Hamano
2024-03-19 20:57 ` Jeff King
2024-03-19 21:00 ` Junio C Hamano [this message]
2024-03-19 21:11 ` Jeff King
2024-03-19 21:44 ` Junio C Hamano
2024-03-21 0:11 ` Chris Torek
2024-03-19 20:56 ` Jeff King
2024-03-19 18:37 ` [PATCH v3 2/2] config: learn the "hostname:" includeIf condition Ignacio Encinas
2024-03-19 20:53 ` Junio C Hamano
2024-03-19 21:04 ` Jeff King
2024-03-19 21:32 ` Ignacio Encinas Rubio
2024-03-19 20:55 ` [PATCH v3 0/2] Add hostname condition to includeIf Eric Sunshine
2024-03-19 21:12 ` Junio C Hamano
2024-03-19 21:13 ` Eric Sunshine
2024-03-20 0:19 ` Jeff King
2024-03-20 2:49 ` Eric Sunshine
2024-03-20 3:07 ` Eric Sunshine
2024-03-20 14:34 ` Chris Torek
2024-03-20 16:37 ` Eric Sunshine
2024-03-20 20:51 ` Jeff King
2024-03-20 16:49 ` Junio C Hamano
2024-03-19 21:36 ` Dirk Gouders
2024-03-19 22:03 ` rsbecker
2024-03-19 22:26 ` Dirk Gouders
2024-03-19 22:31 ` rsbecker
2024-03-19 22:59 ` Junio C Hamano
2024-03-19 21:22 ` Ignacio Encinas Rubio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7balyx9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ignacio@iencinas.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.