From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] receive-pack: fix stale packfile locks when dying
Date: Thu, 09 Mar 2023 10:49:01 -0800 [thread overview]
Message-ID: <xmqqo7p1ahgi.fsf@gitster.g> (raw)
In-Reply-To: <xmqqsfedahhl.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 09 Mar 2023 10:48:22 -0800")
Junio C Hamano <gitster@pobox.com> writes:
>> @@ -2281,6 +2287,7 @@ static const char *unpack(int err_fd, struct shallow_info *si)
>> if (status)
>> return "index-pack fork failed";
>> pack_lockfile = index_pack_lockfile(child.out, NULL);
>> + atexit(unlink_pack_lockfile);
>
> Hmph, why isn't this a straight application of tempfile API?
Ah, sorry, that has already been raised in the thread. I should
have checked first.
Sorry for the noise.
next prev parent reply other threads:[~2023-03-09 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 13:09 [PATCH] receive-pack: fix stale packfile locks when dying Patrick Steinhardt
2023-03-09 15:59 ` Jeff King
2023-03-10 6:24 ` Patrick Steinhardt
2023-03-10 8:37 ` Jeff King
2023-03-09 18:26 ` Taylor Blau
2023-03-09 18:48 ` Junio C Hamano
2023-03-09 18:49 ` Junio C Hamano [this message]
2023-03-10 6:52 ` [PATCH v2] " Patrick Steinhardt
2023-03-10 8:51 ` Jeff King
2023-03-10 11:49 ` Patrick Steinhardt
2023-03-10 13:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7p1ahgi.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.