From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] format-patch: output header for empty commits
Date: Wed, 08 Mar 2023 12:43:45 -0800 [thread overview]
Message-ID: <xmqqo7p3rn26.fsf@gitster.g> (raw)
In-Reply-To: <ZAjxL2MIXCNZgYj/@keeping.me.uk> (John Keeping's message of "Wed, 8 Mar 2023 20:33:51 +0000")
John Keeping <john@keeping.me.uk> writes:
>> Overall, if we were designing format-patch/send-email/am today with
>> today's use cases in mind without any existing users of these three
>> commands, I think these three would be designed to pass an empty
>> commit through the chain unconditionally. But we do not live in
>> such a world, so perhaps some sort of opting in may be appropriate.
>
> Does that mean you want to see format-patch die on empty commits unless
> --allow-empty is specified?
No, what I (with Devil's advocate hat on) suggested was to hide the
"instead of leaving an empty file, fill the file with the log message"
feature this patch adds behind --allow-empty option, and when the
option is not given, keep the current behaviour.
prev parent reply other threads:[~2023-03-08 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 16:03 [PATCH] format-patch: output header for empty commits John Keeping
2023-03-03 17:13 ` Junio C Hamano
2023-03-04 10:45 ` John Keeping
2023-03-06 17:08 ` Junio C Hamano
2023-03-08 20:33 ` John Keeping
2023-03-08 20:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7p3rn26.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.