From: Junio C Hamano <gitster@pobox.com>
To: "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Oscar Dominguez <dominguez.celada@gmail.com>
Subject: Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2
Date: Mon, 10 Oct 2022 14:00:16 -0700 [thread overview]
Message-ID: <xmqqo7uj1jj3.fsf@gitster.g> (raw)
In-Reply-To: <4ee163b9a2c4c657e649159ae6c83b13613028f3.1665388136.git.gitgitgadget@gmail.com> (Oscar Dominguez via GitGitGadget's message of "Mon, 10 Oct 2022 07:48:56 +0000")
"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to prevent issue tracked in https://github.com/actions/checkout/issues/560
>
> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
> ---
> .github/workflows/main.yml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
So, this is "[Patch 1/2] broke the musl job by blindly updating them
to v3 and here is a fix-up" patch? Can we rearrange so that we have
no such "oops here is a fix" that breaks bisection easily?
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 8dc9d938159..4eb5042f0d6 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -281,17 +281,20 @@ jobs:
> vector:
> - jobname: linux-musl
> image: alpine
> + checkout_version: 3
> - jobname: linux32
> os: ubuntu32
> image: daald/ubuntu32:xenial
> + checkout_version: 2
> - jobname: pedantic
> image: fedora
> + checkout_version: 3
> env:
> jobname: ${{matrix.vector.jobname}}
> runs-on: ubuntu-latest
> container: ${{matrix.vector.image}}
> steps:
> - - uses: actions/checkout@v3
> + - uses: actions/checkout@${{matrix.vector.checkout_version}}
> - run: ci/install-docker-dependencies.sh
> - run: ci/run-build-and-tests.sh
> - name: print test failures
next prev parent reply other threads:[~2022-10-10 21:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55 ` Junio C Hamano
2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00 ` Junio C Hamano [this message]
2022-10-10 21:43 ` Junio C Hamano
2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-12-05 23:28 ` Junio C Hamano
2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21 ` Johannes Schindelin
2022-12-06 23:41 ` Junio C Hamano
2022-12-07 0:35 ` Junio C Hamano
2022-12-07 12:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7uj1jj3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dominguez.celada@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.