From: Junio C Hamano <gitster@pobox.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Rasmus Villemoes <rv@rasmusvillemoes.dk>,
Git Mailing List <git@vger.kernel.org>,
Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: Re: forcing an in-body From header
Date: Fri, 26 Aug 2022 10:20:45 -0700 [thread overview]
Message-ID: <xmqqo7w6yl8y.fsf@gitster.g> (raw)
In-Reply-To: <20220826164828.cxsveqtjiyimdj7s@meerkat.local> (Konstantin Ryabitsev's message of "Fri, 26 Aug 2022 12:48:28 -0400")
Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:
> I agree that it's a nice feature to have, though I would put this into the
> sendemail config instead of using an env variable, something like:
>
> [sendemail]
> in-body-headers = From
A change only for send-email does sound quite attractive.
I encourage folks to run format-patch first, make amends as needed
in the output files, proofread the result once again, all before
finally handing it to send-email for sending out. If a "force
in-body headers" command line option plus a configuration variable
added to "git send-email" would work for them, I would be OK with
such a change.
There may be folks who do not use "git send-email" to send out their
patches, and a change to "git format-patch" may help them, though.
Thanks.
next prev parent reply other threads:[~2022-08-26 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 13:17 forcing an in-body From header Rasmus Villemoes
2022-08-26 16:48 ` Konstantin Ryabitsev
2022-08-26 17:20 ` Junio C Hamano [this message]
2022-08-29 11:56 ` Rasmus Villemoes
2022-08-26 17:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7w6yl8y.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=luca.ceresoli@bootlin.com \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.