All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: "Hamza Mahfooz" <someguy@effective-light.com>,
	git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
	"Andreas Schwab" <schwab@linux-m68k.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 1/2] grep/pcre2: limit the instances in which UTF mode is enabled
Date: Thu, 18 Nov 2021 12:53:56 -0800	[thread overview]
Message-ID: <xmqqo86hw5gb.fsf@gitster.g> (raw)
In-Reply-To: <YZasJWuysic3OWS1@carlos-mbp.lan> ("Carlo Marcelo Arenas Belón"'s message of "Thu, 18 Nov 2021 11:40:21 -0800")

Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:

> I have to admit that adding to a complex condition might be obscuring
> some other edge case, and indeed the fact the test passed even without
> this fix is concerning.
>
> From my reading of what Ævar suggested originally[1], it would seem that
> the new is_log condition should be on an branch of its own, and more code
> should be needed to make sure the contents we are going to use are indeed
> utf8 by the time it hits pcre2_*match() before setting it.

At least, let's not consider pursuing this approach to pile on more
iffy code on top of broken code in the release.  Unless I hear
otherwise, I am leaning to revert the whole three patches of the
original series and call it a day for both 'maint' (for 2.34.1) and
'master'.

Thanks.

      reply	other threads:[~2021-11-18 20:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18  8:41 [PATCH 1/2] grep/pcre2: limit the instances in which UTF mode is enabled Hamza Mahfooz
2021-11-18  8:41 ` [PATCH 2/2] ci: add a job for PCRE2 Hamza Mahfooz
2021-11-18  9:53   ` [PATCH v2 " Hamza Mahfooz
2021-11-18 10:32   ` [PATCH " Ævar Arnfjörð Bjarmason
2021-11-22 22:26     ` Hamza Mahfooz
2021-11-18 10:04 ` [PATCH 1/2] grep/pcre2: limit the instances in which UTF mode is enabled Carlo Arenas
2021-11-18 19:40   ` Carlo Marcelo Arenas Belón
2021-11-18 20:53     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo86hw5gb.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=schwab@linux-m68k.org \
    --cc=someguy@effective-light.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.