From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 1/2] t6300: don't run cat-file on non-existent object
Date: Thu, 19 Aug 2021 13:16:37 -0700 [thread overview]
Message-ID: <xmqqo89tyyu2.fsf@gitster.g> (raw)
In-Reply-To: <b813d6f2ad96d79a8904ef8b255d4b73ea6567d2.1629263759.git.congdanhqx@gmail.com> ("Đoàn Trần Công Danh"'s message of "Wed, 18 Aug 2021 12:19:26 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> In t6300, some tests are guarded behind some prerequisites.
> Thus, objects created by those tests ain't available if those
> prerequisites is unsatistified. Attempting to run "cat-file"
is -> are.
> on those objects will run into failure.
>
> In fact, running t6300 in an environment without gpg(1),
> we'll see those warnings:
>
> fatal: Not a valid object name refs/tags/signed-empty
> fatal: Not a valid object name refs/tags/signed-short
> fatal: Not a valid object name refs/tags/signed-long
>
> Let's put those commands into the real tests, in order to:
>
> * skip their execution if prerequisites aren't satistified.
> * check their exit status code
>
> The expected value for objects with type: commit needs to be
> computed outside the test because we can't relies on "$3" there.
relies -> rely
next prev parent reply other threads:[~2021-08-19 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 11:48 [PATCH] t6300: don't run cat-file on non-existent object Đoàn Trần Công Danh
2021-08-17 21:44 ` Johannes Schindelin
2021-08-18 5:19 ` [PATCH v2 0/2] t6300: clear warning when running without gpg Đoàn Trần Công Danh
2021-08-18 5:19 ` [PATCH v2 1/2] t6300: don't run cat-file on non-existent object Đoàn Trần Công Danh
2021-08-19 20:16 ` Junio C Hamano [this message]
2021-08-18 5:19 ` [PATCH v2 2/2] t6300: check for cat-file exit status code Đoàn Trần Công Danh
2021-08-19 20:19 ` Junio C Hamano
2021-08-18 10:33 ` [PATCH v2 0/2] t6300: clear warning when running without gpg Johannes Schindelin
2021-08-21 1:36 ` [PATCH v3 " Đoàn Trần Công Danh
2021-08-21 1:36 ` [PATCH v3 1/2] t6300: don't run cat-file on non-existent object Đoàn Trần Công Danh
2021-08-21 1:36 ` [PATCH v3 2/2] t6300: check for cat-file exit status code Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo89tyyu2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.