From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] builtin/blame: darken redundant line information
Date: Tue, 13 Jun 2017 10:19:55 -0700 [thread overview]
Message-ID: <xmqqo9tr7qkk.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYV8Ngis=ux50Zs1r5XOBUJ=hw2=8BEkNqk7PiGamX0AA@mail.gmail.com> (Stefan Beller's message of "Tue, 13 Jun 2017 10:13:43 -0700")
Stefan Beller <sbeller@google.com> writes:
> Here is what currently happens:
>
>>
>> context
>> -B dim oldMoved
>> -B dim oldMoved
>> -B highlight oldMovedAlternative
>> -A highlight oldMovedAlternative
>> -A dim oldMoved
>> -A dim oldMoved
>> context
>> +A dim newMoved
>> +A dim newMoved
>> +A highlight newMovedAlternative
>> +B highlight newMovedAlternative
>> +B dim newMoved
>> +B dim newMoved
>> context
>>
>
> So the there is only one "highlight" color in each block.
> There is no separate hightligh-for-ending-block and
> highlight-for-new-block respectively.
I think the adjacentbounds mode is simply broken if that is the
design.
In the above simplified case, you can get away with only a single
"highlight" color, but you cannot tell where the boundaries are when
three or more lines are shuffled, no?
next prev parent reply other threads:[~2017-06-13 17:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 2:31 [RFC/PATCH] builtin/blame: darken redundant line information Stefan Beller
2017-06-13 15:25 ` Junio C Hamano
2017-06-13 16:21 ` Stefan Beller
2017-06-13 17:00 ` Junio C Hamano
2017-06-13 17:13 ` Stefan Beller
2017-06-13 17:19 ` Junio C Hamano [this message]
2017-06-13 17:30 ` Stefan Beller
2017-06-13 17:33 ` Junio C Hamano
2017-06-13 17:44 ` Stefan Beller
2017-06-13 17:48 ` Junio C Hamano
2017-06-13 18:00 ` Stefan Beller
2017-06-13 18:06 ` Junio C Hamano
2017-06-13 23:42 ` Jonathan Tan
2017-06-14 0:33 ` Stefan Beller
2017-07-26 23:04 ` [PATCHv2] builtin/blame: highlight interesting things Stefan Beller
2017-07-26 23:29 ` Junio C Hamano
2017-07-26 23:57 ` Stefan Beller
2017-07-27 18:27 ` Junio C Hamano
2017-07-27 18:57 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9tr7qkk.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.