From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>, neuling@dakosy.de
Subject: Re: Re* git pull --rebase should use fast forward merge if possible
Date: Thu, 01 Dec 2016 10:50:59 -0800 [thread overview]
Message-ID: <xmqqoa0va3fw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kZSEan5uXCUn4iVCWEc9zohMSr+UDyHDyQUHz84H=tR8w@mail.gmail.com> (Stefan Beller's message of "Thu, 1 Dec 2016 10:24:49 -0800")
Stefan Beller <sbeller@google.com> writes:
> On Thu, Dec 1, 2016 at 9:59 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> +test_expect_success '--rebase fast forward' '
>> + git reset --hard before-rebase &&
>> + git checkout -b ff &&
>> + echo another modification >file &&
>> + git commit -m third file &&
>> +
>> + git checkout to-rebase &&
>> + git pull --rebase . ff &&
>> + test "$(git rev-parse HEAD)" = "$(git rev-parse ff)" &&
>> +
>> + # The above only validates the result. Did we actually bypass rebase?
>
> Good catch for the test, but I think we can make the sed regexp simpler, as we
> can leave out the second "[0-9a-f]"? (git reflog |sed
> "s/^[0-9a-f]*/OBJID/" works here)
This mimics the existing tests around there for consistency.
Simplifying or cleaning of this test script as a whole is outside
the scope.
next prev parent reply other threads:[~2016-12-01 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 16:18 git pull --rebase should use fast forward merge if possible neuling
2016-06-29 16:32 ` Junio C Hamano
2016-06-29 17:23 ` Junio C Hamano
2016-06-29 20:40 ` Stefan Beller
2016-06-29 20:43 ` Junio C Hamano
2016-12-01 17:59 ` Re* " Junio C Hamano
2016-12-01 18:24 ` Stefan Beller
2016-12-01 18:50 ` Junio C Hamano [this message]
2016-12-01 18:51 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa0va3fw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=neuling@dakosy.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.