From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, rappazzo@gmail.com
Subject: Re: [PATCH v2 0/5] nd/worktree-list-fixup
Date: Mon, 28 Nov 2016 13:25:57 -0800 [thread overview]
Message-ID: <xmqqoa0zi9ei.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161128093656.15744-1-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Mon, 28 Nov 2016 16:36:51 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> This version
>
> * changes get_worktrees() to take a flag, and adds one flag for
> sorting.
>
> * adds tests for both the 'main worktree always present' and the
> sorting problems.
>
> * reworks 3/5 a bit, keep changes closer, easier to see the cause and
> consequence.
>
> Nguyễn Thái Ngọc Duy (5):
> worktree.c: zero new 'struct worktree' on allocation
> worktree: reorder an if statement
> get_worktrees() must return main worktree as first item even on error
> worktree.c: get_worktrees() takes a new flag argument
> worktree list: keep the list sorted
>
> branch.c | 2 +-
> builtin/branch.c | 2 +-
> builtin/worktree.c | 14 ++++++++------
> t/t2027-worktree-list.sh | 40 ++++++++++++++++++++++++++++++++++++++++
> worktree.c | 42 +++++++++++++++++++++---------------------
> worktree.h | 4 +++-
> 6 files changed, 74 insertions(+), 30 deletions(-)
Thanks for a pleasant read. Will replace what has been queued.
prev parent reply other threads:[~2016-11-28 21:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:00 [PATCH 0/3] Minor fixes on 'git worktree' Nguyễn Thái Ngọc Duy
2016-11-22 10:00 ` [PATCH 1/3] worktree.c: zero new 'struct worktree' on allocation Nguyễn Thái Ngọc Duy
2016-11-23 16:52 ` Junio C Hamano
2016-11-22 10:00 ` [PATCH 2/3] get_worktrees() must return main worktree as first item even on error Nguyễn Thái Ngọc Duy
2016-11-23 17:06 ` Junio C Hamano
2016-11-22 10:00 ` [PATCH 3/3] worktree list: keep the list sorted Nguyễn Thái Ngọc Duy
2016-11-23 17:16 ` Junio C Hamano
2016-11-25 12:19 ` Duy Nguyen
2016-11-23 16:52 ` [PATCH 0/3] Minor fixes on 'git worktree' Junio C Hamano
2016-11-25 12:24 ` Duy Nguyen
2016-11-25 13:44 ` Duy Nguyen
2016-11-28 19:36 ` Junio C Hamano
2016-11-28 9:36 ` [PATCH v2 0/5] nd/worktree-list-fixup Nguyễn Thái Ngọc Duy
2016-11-28 9:36 ` [PATCH v2 1/5] worktree.c: zero new 'struct worktree' on allocation Nguyễn Thái Ngọc Duy
2016-11-28 9:36 ` [PATCH v2 2/5] worktree: reorder an if statement Nguyễn Thái Ngọc Duy
2016-11-28 9:36 ` [PATCH v2 3/5] get_worktrees() must return main worktree as first item even on error Nguyễn Thái Ngọc Duy
2016-11-28 9:36 ` [PATCH v2 4/5] worktree.c: get_worktrees() takes a new flag argument Nguyễn Thái Ngọc Duy
2016-11-28 9:36 ` [PATCH v2 5/5] worktree list: keep the list sorted Nguyễn Thái Ngọc Duy
2016-11-28 21:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa0zi9ei.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=rappazzo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.