From: Junio C Hamano <gitster@pobox.com>
To: Kevin Daudt <me@ikke.info>
Cc: git@vger.kernel.org, Swift Geek <swiftgeek@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v4 1/2] t5100-mailinfo: replace common path prefix with variable
Date: Wed, 28 Sep 2016 13:21:13 -0700 [thread overview]
Message-ID: <xmqqoa37ixmu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160928195232.7843-1-me@ikke.info> (Kevin Daudt's message of "Wed, 28 Sep 2016 21:52:31 +0200")
Kevin Daudt <me@ikke.info> writes:
> Many tests need to store data in a file, and repeat the same pattern to
> refer to that path:
>
> "$TEST_DIRECTORY"/t5100/
>
> Create a variable that contains this path, and use that instead.
>
> While we're making this change, make sure the quotes are not just around
> the variable, but around the entire string to not give the impression
> we want shell splitting to affect the other variables.
Wow. I was half expecting that you'd say something like "1/2 plus
the SQUASH is OK by me", but you went extra mile to do it right.
Impressed, and very much appreciated.
next prev parent reply other threads:[~2016-09-28 20:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 21:02 [PATCH] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-16 22:22 ` Jeff King
2016-09-19 10:51 ` Kevin Daudt
2016-09-20 3:57 ` Jeff King
2016-09-21 16:07 ` Junio C Hamano
2016-09-19 18:54 ` [PATCH v2 0/2] Handle escape characters in From field Kevin Daudt
2016-09-25 21:08 ` [PATCH v3 1/2] t5100-mailinfo: replace common path prefix with variable Kevin Daudt
2016-09-25 21:08 ` [PATCH v3 2/2] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-26 19:11 ` Junio C Hamano
2016-09-26 19:26 ` Junio C Hamano
2016-09-26 19:44 ` Kevin Daudt
2016-09-26 22:23 ` Junio C Hamano
2016-09-27 10:26 ` Kevin Daudt
2016-09-26 19:06 ` [PATCH v3 1/2] t5100-mailinfo: replace common path prefix with variable Junio C Hamano
2016-09-28 19:49 ` [PATCH v4 0/2] Handle RFC2822 quoted-pairs in From header Kevin Daudt
2016-09-28 19:52 ` [PATCH v4 1/2] t5100-mailinfo: replace common path prefix with variable Kevin Daudt
2016-09-28 20:21 ` Junio C Hamano [this message]
2016-09-28 20:27 ` Kevin Daudt
2016-09-28 19:52 ` [PATCH v4 2/2] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-19 18:54 ` [PATCH v2 1/2] t5100-mailinfo: replace common path prefix with variable Kevin Daudt
2016-09-19 21:16 ` Junio C Hamano
2016-09-20 3:59 ` Jeff King
2016-09-19 18:54 ` [PATCH v2 2/2] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-19 21:24 ` Junio C Hamano
2016-09-19 22:04 ` Junio C Hamano
2016-09-20 4:28 ` Jeff King
2016-09-21 11:09 ` Jeff King
2016-09-22 22:17 ` Junio C Hamano
2016-09-23 4:15 ` Jeff King
2016-09-25 20:17 ` Kevin Daudt
2016-09-25 22:38 ` Jakub Narębski
2016-09-26 5:02 ` Kevin Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa37ixmu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
--cc=peff@peff.net \
--cc=swiftgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.