From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Armin Kunaschik <megabreit@googlemail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/6] test -z/-n quoting fix + misc cleanups
Date: Fri, 13 May 2016 15:09:51 -0700 [thread overview]
Message-ID: <xmqqoa898v9s.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160513204654.GA10684@sigill.intra.peff.net> (Jeff King's message of "Fri, 13 May 2016 16:46:54 -0400")
Jeff King <peff@peff.net> writes:
> Anyway. Here's a series that fixes the -n/-z cases, along with a bunch
> of cleanups that remove the false positives (most of which I sent out
> just a few minutes ago as "minor fixes to some svn tests").
>
> [1/6]: t/lib-git-svn: drop $remote_git_svn and $git_svn_id
> [2/6]: t9100,t3419: enclose all test code in single-quotes
> [3/6]: t9107: use "return 1" instead of "exit 1"
> [4/6]: t9107: switch inverted single/double quotes in test
> [5/6]: t9103: modernize test style
> [6/6]: always quote shell arguments to test -z/-n
All look sensible; thanks.
prev parent reply other threads:[~2016-05-13 22:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 16:09 t3404 static check of bad SHA-1 failure Armin Kunaschik
2016-05-13 18:23 ` Jeff King
2016-05-13 19:52 ` Junio C Hamano
2016-05-13 19:59 ` Jeff King
2016-05-13 20:02 ` Jeff King
2016-05-13 20:03 ` Junio C Hamano
2016-05-13 20:46 ` [PATCH 0/6] test -z/-n quoting fix + misc cleanups Jeff King
2016-05-13 20:47 ` [PATCH 1/6] t/lib-git-svn: drop $remote_git_svn and $git_svn_id Jeff King
2016-05-13 20:47 ` [PATCH 2/6] t9100,t3419: enclose all test code in single-quotes Jeff King
2016-05-13 20:47 ` [PATCH 3/6] t9107: use "return 1" instead of "exit 1" Jeff King
2016-05-13 22:59 ` Eric Wong
2016-05-13 23:45 ` Eric Sunshine
2016-05-13 23:47 ` Jeff King
2016-05-14 17:37 ` Junio C Hamano
2016-05-14 19:51 ` Jeff King
2016-05-13 20:47 ` [PATCH 4/6] t9107: switch inverted single/double quotes in test Jeff King
2016-05-13 20:47 ` [PATCH 5/6] t9103: modernize test style Jeff King
2016-05-13 20:47 ` [PATCH 6/6] always quote shell arguments to test -z/-n Jeff King
2016-05-13 22:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa898v9s.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=megabreit@googlemail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.