All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
Date: Thu, 08 Jan 2015 12:14:41 -0800	[thread overview]
Message-ID: <xmqqoaq9do7i.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54AED7C3.8010604@web.de> ("René Scharfe"'s message of "Thu, 08 Jan 2015 20:17:23 +0100")

René Scharfe <l.s.r@web.de> writes:

> Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov:
>> git remote show doesn't use -v/--verbose option
>
> Hmm, but it does?
>
> 	$ git version
> 	git version 2.2.1
> 	$ git remote show
> 	origin
> 	$ git remote -v show
> 	origin  git://git.kernel.org/pub/scm/git/git.git (fetch)
> 	origin  git://git.kernel.org/pub/scm/git/git.git (push)
>
> Perhaps you meant the following variant?  The changed line documents
> the one above, though (-v before show).
>
> 	$ git remote show -v
> 	error: unknown switch `v'
> 	usage: git remote show [<options>] <name>
>
> 	    -n                    do not query remotes

Ahh, I misread the patch.  Thanks.

>> diff --git a/builtin/remote.c b/builtin/remote.c
>> index 46ecfd9..978c645 100644
>> --- a/builtin/remote.c
>> +++ b/builtin/remote.c
>> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {
>>   	N_("git remote rename <old> <new>"),
>>   	N_("git remote remove <name>"),
>>   	N_("git remote set-head <name> (-a | --auto | -d | --delete |<branch>)"),
>> -	N_("git remote [-v | --verbose] show [-n] <name>"),
>> +	N_("git remote show [-n] <name>"),
>>   	N_("git remote prune [-n | --dry-run] <name>"),
>>   	N_("git remote [-v | --verbose] update [-p | --prune] [(<group> | <remote>)...]"),
>>   	N_("git remote set-branches [--add] <name> <branch>..."),
>>

I however have a bit larger question.  Does it make sense to have
[-v/--verbose] in front of some but not all of the subcommands?

For example, the above snippet gives me an impression that

    $ git remote -v prune -n origin

should not work, but that does not seem to be the case.

  parent reply	other threads:[~2015-01-08 20:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 17:57 [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis Alexander Kuleshov
2015-01-08 19:17 ` René Scharfe
2015-01-08 19:22   ` Alexander Kuleshov
2015-01-08 20:14   ` Junio C Hamano [this message]
2015-01-08 20:32     ` Alexander Kuleshov
2015-01-08 19:47 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqoaq9do7i.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kuleshovmail@gmail.com \
    --cc=l.s.r@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.