From: Junio C Hamano <gitster@pobox.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Johan Herland <johan@herland.net>,
"James H. Fisher" <jhf@trifork.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Bug/request: the empty string should be a valid git note
Date: Mon, 22 Sep 2014 10:39:00 -0700 [thread overview]
Message-ID: <xmqqoau7lfm3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1A2394C0-50A4-40F4-B0B9-B2EC38109083@gmail.com> (Kyle J. McKay's message of "Sun, 21 Sep 2014 16:32:51 -0700")
"Kyle J. McKay" <mackyle@gmail.com> writes:
> On Sep 20, 2014, at 18:44, Johan Herland wrote:
>
>> At least, we should fix
>>
>> git notes add -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
>>
>> Whether we should also change
>>
>> git notes add -m ''
>>
>> to create an empty note, or leave it as-is, (i.e. similar in spirit to
>> "git commit -m ''"), I'll leave up to further discussion.
>
> The help for git commit has this:
>
> --allow-empty-message
> Like --allow-empty this command is primarily for use by
> foreign SCM interface scripts. It allows you to create
> a commit with an empty commit message without using
> plumbing commands like git-commit-tree(1).
>
> Why not add the same/similar option to git notes add?
Sounds like a good direction to go.
prev parent reply other threads:[~2014-09-22 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 19:47 Bug/request: the empty string should be a valid git note James H. Fisher
2014-09-20 21:50 ` James H. Fisher
2014-09-21 1:44 ` Johan Herland
2014-09-21 3:00 ` [RFC/PATCH] notes: Allow adding empty notes with -C Johan Herland
2014-09-21 8:53 ` Torsten Bögershausen
2014-09-21 9:46 ` Johan Herland
2014-09-21 23:32 ` Bug/request: the empty string should be a valid git note Kyle J. McKay
2014-09-22 17:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoau7lfm3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jhf@trifork.com \
--cc=johan@herland.net \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.