From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] credential-cache: close stderr in daemon process
Date: Mon, 15 Sep 2014 14:38:11 -0700 [thread overview]
Message-ID: <xmqqoaug4la4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140914073506.GA19667@peff.net> (Jeff King's message of "Sun, 14 Sep 2014 03:35:06 -0400")
Jeff King <peff@peff.net> writes:
> + if (!debug)
> + freopen("/dev/null", "w", stderr);
I am getting this:
credential-cache--daemon.c:216:10: error: ignoring return value of
'freopen', declared with attribute warn_unused_result
[-Werror=unused-result]
which is somewhat irritating. Even though I am not irritated by
this code, but by the compiler and glibc headers, this is apparently
the only offending one, so we may want to fix it anyway.
next prev parent reply other threads:[~2014-09-15 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 7:35 [PATCH] credential-cache: close stderr in daemon process Jeff King
2014-09-15 21:38 ` Junio C Hamano [this message]
2014-09-16 0:28 ` Jeff King
2014-09-16 18:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoaug4la4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.