From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
Christian Couder <chriscool@tuxfamily.org>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] replace: add --graft option
Date: Mon, 19 May 2014 11:34:54 -0700 [thread overview]
Message-ID: <xmqqoayt1usx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140519173505.GA28673@sigill.intra.peff.net> (Jeff King's message of "Mon, 19 May 2014 13:35:05 -0400")
Jeff King <peff@peff.net> writes:
> On Mon, May 19, 2014 at 10:25:10AM -0700, Junio C Hamano wrote:
>
>> The headers up to committer are cast in stone in their ordering, and
>> I do not immediately see how loosening it would be beneficial.
>>
>> Unless you are trying to give users a new way to record exactly the
>> same commit in twenty-four (or more) ways with their own object
>> names, that is ;-)
>
> Sorry, I didn't mean to imply that people can do what they want with
> that ordering. Implementations that reorder the headers are stupid and
> wrong, and should be fixed.
Yeah, that was the only thing I meant to say, and what you said in
the rest of message makes sense to me. I very much like the
approach to parse line-by-line, noticing products from stupid and
wrong implementations and warning or erroring out against them,
while allowing an option to be lenient to help users who want to fix
their repositories contaminated with such objects.
next prev parent reply other threads:[~2014-05-19 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 18:29 [RFC/PATCH] replace: add --graft option Christian Couder
2014-05-19 9:42 ` Michael Haggerty
2014-05-19 11:19 ` Jeff King
2014-05-19 17:25 ` Junio C Hamano
2014-05-19 17:35 ` Jeff King
2014-05-19 18:34 ` Junio C Hamano [this message]
2014-05-23 6:39 ` Christian Couder
2014-05-19 11:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoayt1usx.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.