All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nazri Ramliy <ayiehere@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
	Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v4] Teach git to change to a given directory using -C option
Date: Thu, 19 Sep 2013 10:13:51 -0700	[thread overview]
Message-ID: <xmqqob7ou434.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130919131854.GA19790@gmail.com> (Nazri Ramliy's message of "Thu, 19 Sep 2013 21:18:54 +0800")

Nazri Ramliy <ayiehere@gmail.com> writes:

> Now I'm noticing that you've already made the above fixes in next ;)

Yes.  I said I'd locally tweak and queue, didn't I?

>>> +test_expect_success '"git -C <path>" runs git from the directory <path>' '
>>> +     test_create_repo dir1 &&
>>> +     echo 1 >dir1/a.txt &&
>>> +     (cd dir1 && git add a.txt && git commit -m "initial in dir1") &&
>>
>> Curious why this does not use -C here.
>
> It didn't use -C there because it's in the "prepare the expected test
> output" stage and we want that to succeed, whether -C works or not - we
> haven't reached the part where we are actually testing the -C option,

Good thinking.

Will queue as an incremental update on top of what is already in 'next'.

Thanks.

      reply	other threads:[~2013-09-19 17:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 13:18 [PATCH v4] Teach git to change to a given directory using -C option Nazri Ramliy
2013-09-19 17:13 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqob7ou434.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=ayiehere@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.