All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Joshua Jensen <jjensen@workspacewhiz.com>,
	Brian Gernhardt <brian@gernhardtsoftware.com>
Subject: Re: [PATCH v2 0/2] fix t3010 failure when core.ignorecase=true
Date: Fri, 23 Aug 2013 14:00:06 -0700	[thread overview]
Message-ID: <xmqqob8onmw9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1377289759-46838-1-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Fri, 23 Aug 2013 16:29:17 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Recent mailing list discussion [2][3] suggests that changes at a more
> fundamental level (if they pan out) would be a more appropriate approach
> to resolving this bug.  Such an approach would (happily) make patch 2/2
> unnecessary, however, I'm posting this series for posterity since it was
> already written before [2][3].

Fair enough.

In the meantime, given the reaction from Peff, I am tempted to
squash your "work around in the caller side" as a fix to 2eac2a4c
(ls-files -k: a directory only can be killed if the index has a
non-directory, 2013-08-15) and squash in the patch to run "ls-files
-k" with "-c core.ignorecase=true" to 3c568751 (t3010: update to
demonstrate "ls-files -k" optimization pitfalls, 2013-08-15). That
way, the eventual fix of not adding '/' at the end do not have to
revert the changes to the caller, and the tests added to t3010 by
the latter will be "optimization pitfalls" as before.

Thanks.

  parent reply	other threads:[~2013-08-23 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 20:29 [PATCH v2 0/2] fix t3010 failure when core.ignorecase=true Eric Sunshine
2013-08-23 20:29 ` [PATCH v2 1/2] t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure Eric Sunshine
2013-08-23 20:29 ` [PATCH v2 2/2] dir: fix core.ignorecase inconsistency with missing '/' Eric Sunshine
2013-08-23 21:00 ` Junio C Hamano [this message]
2013-08-23 21:04   ` [PATCH v2 0/2] fix t3010 failure when core.ignorecase=true Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqob8onmw9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=jjensen@workspacewhiz.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.