All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: kristofferhaugsbakk@fastmail.com,  git@vger.kernel.org,
	 Kristoffer Haugsbakk <code@khaugsbakk.name>,
	 christian.couder@gmail.com,
	 Brendan Jackman <bhenryj0117@gmail.com>,
	 Linus Arver <linus@ucla.edu>,  Matt Hunter <m@lfurio.us>
Subject: Re: [PATCH v5 00/11] doc: interpret-trailers: explain key format
Date: Mon, 10 Aug 2026 16:08:21 -0700	[thread overview]
Message-ID: <xmqqpkzp60be.fsf@gitster.g> (raw)
In-Reply-To: <0687D60D-DF6B-4547-868C-FCFC5B27ECAF@gmail.com> (Ben Knoble's message of "Mon, 10 Aug 2026 07:16:56 -0400")

Ben Knoble <ben.knoble@gmail.com> writes:

>> § Link to v4
>> 
>> https://lore.kernel.org/git/V4_CV_doc_int-tr_key_format.ae2@msgid.xyz/
>> 
>> [01/11] doc: interpret-trailers: stop fixating on RFC 822
>> [02/11] doc: interpret-trailers: replace “lines” with “metadata”
>> [03/11] doc: interpret-trailers: use “metadata” in Name as well
>> [04/11] doc: interpret-trailers: not just for commit messages
>> [05/11] doc: interpret-trailers: explain the format after the intro
>> [06/11] doc: interpret-trailers: explain key format
>> [07/11] doc: interpret-trailers: add key format example
>> [08/11] doc: interpret-trailers: join new-trailers again
>> [09/11] doc: interpret-trailers: commit to “trailer block” term
>> [10/11] doc: interpret-trailers: rewrite new-trailers paragraphs
>> [11/11] doc: interpret-trailers: document comment line treatment

[...]

>>    @@ Commit message
>> 
>>         Comment lines have always been ignored but this is not documented.
>> 
>>    -    The primary motivation here is to reasonably complete in the
>>    +    The primary motivation here is to be reasonably complete in the
>>         documentation of how trailers are parsed; this is after all the only
>>         documentation page that documents this format. However, and going beyond
>>         that point, we could imagine that someone would want to use this format
>> 
>> base-commit: 5361983c075154725be47b65cca9a2421789e410
>> --
>> 2.54.0.22.g9e26862b904
>
> I’m trivially satisfied with the range-diff (note again I’ve reviewed primarily the end result, not the per-commit history).

Heh, that is like saying it is better with "be" than without ;-).

I think the topic was already in pretty good shape by 'v4'.  Shall
we declare victory and mark the topic for 'next'?

Thanks.

      parent reply	other threads:[~2026-08-10 23:08 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 13:27 git-interpret-trailers and period characters in the key Brendan Jackman
2025-04-03 11:07 ` Christian Couder
2025-04-07 20:37   ` Junio C Hamano
2026-03-30 21:11 ` [PATCH 0/2] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-03-30 21:11   ` [PATCH 1/2] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-03-30 22:27     ` Junio C Hamano
2026-03-30 22:56       ` Kristoffer Haugsbakk
2026-03-30 23:24         ` Junio C Hamano
2026-03-30 21:11   ` [PATCH 2/2] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-03-30 21:55     ` Junio C Hamano
2026-03-30 22:23       ` Kristoffer Haugsbakk
2026-03-31 12:35         ` Ben Knoble
2026-03-31 16:03           ` Kristoffer Haugsbakk
2026-04-13 10:20   ` [PATCH v2 0/9] " kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 1/9] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 2/9] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 3/9] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 4/9] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 5/9] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 6/9] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 7/9] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 8/9] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 9/9] doc: intepret-trailers: document comment line treatment kristofferhaugsbakk
2026-04-13 13:26       ` Kristoffer Haugsbakk
2026-04-13 15:48         ` Junio C Hamano
2026-05-08 15:03           ` Kristoffer Haugsbakk
2026-05-08 15:01     ` [PATCH v2 0/9] doc: interpret-trailers: explain key format Kristoffer Haugsbakk
2026-05-11  2:41       ` Junio C Hamano
2026-05-11 19:23         ` D. Ben Knoble
2026-05-24 12:41           ` Kristoffer Haugsbakk
2026-05-26 21:34             ` Ben Knoble
2026-05-26 21:42               ` Kristoffer Haugsbakk
2026-05-26 21:45                 ` Kristoffer Haugsbakk
2026-06-10 21:21   ` [PATCH v3 00/11] " kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 01/11] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 02/11] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-06-11  3:10       ` Matt Hunter
2026-06-16 20:32         ` Kristoffer Haugsbakk
2026-06-16 21:39           ` Matt Hunter
2026-06-10 21:21     ` [PATCH v3 03/11] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 04/11] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 05/11] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 06/11] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 07/11] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 08/11] doc: interpret-trailers: join new-trailers again kristofferhaugsbakk
2026-06-10 22:00       ` D. Ben Knoble
2026-06-10 22:13         ` Kristoffer Haugsbakk
2026-06-10 21:21     ` [PATCH v3 09/11] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 10/11] doc: interpret-trailers: rewrite new-trailers paragraphs kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 11/11] doc: interpret-trailers: document comment line treatment kristofferhaugsbakk
2026-06-10 22:24     ` [PATCH v3 00/11] doc: interpret-trailers: explain key format Junio C Hamano
2026-06-11 11:57       ` Junio C Hamano
2026-06-11 12:05         ` Kristoffer Haugsbakk
2026-06-11 12:53           ` Kristoffer Haugsbakk
2026-06-17 19:45       ` Kristoffer Haugsbakk
2026-07-23 23:48         ` Junio C Hamano
2026-07-30  9:20           ` Kristoffer Haugsbakk
2026-07-30  9:18   ` [PATCH v4 " kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 01/11] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 02/11] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 03/11] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 04/11] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 05/11] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 06/11] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 07/11] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 08/11] doc: interpret-trailers: join new-trailers again kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 09/11] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 10/11] doc: interpret-trailers: rewrite new-trailers paragraphs kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 11/11] doc: interpret-trailers: document comment line treatment kristofferhaugsbakk
2026-08-06 11:52       ` D. Ben Knoble
2026-08-08 19:45         ` Kristoffer Haugsbakk
2026-08-06 11:55     ` [PATCH v4 00/11] doc: interpret-trailers: explain key format D. Ben Knoble
2026-08-06 20:02       ` Junio C Hamano
2026-08-08 20:02         ` Kristoffer Haugsbakk
2026-08-08 20:01       ` Kristoffer Haugsbakk
2026-08-09 20:06   ` [PATCH v5 " kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 01/11] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 02/11] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 03/11] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 04/11] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 05/11] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 06/11] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 07/11] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 08/11] doc: interpret-trailers: join new-trailers again kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 09/11] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 10/11] doc: interpret-trailers: rewrite new-trailers paragraphs kristofferhaugsbakk
2026-08-09 20:06     ` [PATCH v5 11/11] doc: interpret-trailers: document comment line treatment kristofferhaugsbakk
2026-08-10 11:16     ` [PATCH v5 00/11] doc: interpret-trailers: explain key format Ben Knoble
2026-08-10 14:12       ` Kristoffer Haugsbakk
2026-08-10 23:08       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpkzp60be.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=bhenryj0117@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=linus@ucla.edu \
    --cc=m@lfurio.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.