All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
	Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] codeql: bump actions/cache from 4 to 5
Date: Mon, 13 Apr 2026 11:21:29 -0700	[thread overview]
Message-ID: <xmqqpl42hgba.fsf@gitster.g> (raw)
In-Reply-To: <xmqq7bqaiwm3.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 13 Apr 2026 10:44:04 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>
>> Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5.
>> - [Release notes](https://github.com/actions/cache/releases)
>> - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
>> - [Commits](https://github.com/actions/cache/compare/v4...v5)
>>
>> ---
>>     codeql: bump actions/cache from 4 to 5
>>     
>>     Just a regular GitHub Actions bump
>>
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2086%2Fgit-for-windows%2Fdependabot%2Fgithub_actions%2Factions%2Fcache-5-v1
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2086/git-for-windows/dependabot/github_actions/actions/cache-5-v1
>> Pull-Request: https://github.com/gitgitgadget/git/pull/2086
>>
>> updated-dependencies:
>> - dependency-name: actions/cache
>>   dependency-version: '5'
>>   dependency-type: direct:production
>>   update-type: version-update:semver-major
>> ...
>>
>> Originally-authored-by: dependabot[bot] <support@github.com>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> ---
>
> You should not need to be reminded on how our log messages should
> look like.  Also your sign-off must come before the three-dash line.
>
> Thanks.

A tangent, but I probably should mention that I didn't even notice
the last time we got identically malformatted patch submission in
October,

<2443e519f0ff6160e058d391495dd51256595a48.1760629692.git.gitgitgadget@gmail.com>

which resulted in 63541ed9 (build(deps): bump actions/checkout from
4 to 5, 2025-10-16) that you meant to sign off but ended up
committed without one due to the premature three-dash line.



It seems that GitHub Actions started complaining about use of
Node.js 20 and I was wondering why only one job uses
actions/checkout@v4, and it turns out that it is a semantic mismerge
between e75cd059 (ci: check formatting of our Rust code, 2025-10-15)
that added a new use of actions/checkout@v4 that happened very close
to another change 63541ed9 (build(deps): bump actions/checkout from
4 to 5, 2025-10-16) that updated all uses of actions/checkout@v4 to
use actions/checkout@v5.



      reply	other threads:[~2026-04-13 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 16:24 [PATCH] codeql: bump actions/cache from 4 to 5 Johannes Schindelin via GitGitGadget
2026-04-13 17:44 ` Junio C Hamano
2026-04-13 18:21   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpl42hgba.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.