From: Junio C Hamano <gitster@pobox.com>
To: "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Koji Nakamaru <koji.nakamaru@gree.net>
Subject: Re: [PATCH] osxkeychain: define build targets in the top-level Makefile.
Date: Tue, 10 Feb 2026 11:50:52 -0800 [thread overview]
Message-ID: <xmqqpl6cxtr7.fsf@gitster.g> (raw)
In-Reply-To: <pull.2046.git.1770746461307.gitgitgadget@gmail.com> (Koji Nakamaru via GitGitGadget's message of "Tue, 10 Feb 2026 18:01:01 +0000")
"Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Makefile | 17 +++++++
> contrib/credential/osxkeychain/Makefile | 65 +++----------------------
> 2 files changed, 23 insertions(+), 59 deletions(-)
Nice simplification overall.
> diff --git a/contrib/credential/osxkeychain/Makefile b/contrib/credential/osxkeychain/Makefile
> index c68445b82d..ddb29f0563 100644
> --- a/contrib/credential/osxkeychain/Makefile
> +++ b/contrib/credential/osxkeychain/Makefile
> @@ -1,66 +1,13 @@
> # The default target of this Makefile is...
> all:: git-credential-osxkeychain
>
> -include ../../../config.mak.uname
> --include ../../../config.mak.autogen
> --include ../../../config.mak
> +git-credential-osxkeychain:
> + cd ../../..; make contrib/credential/osxkeychain/git-credential-osxkeychain
Let's not write "make", but stick to $(MAKE), perhaps like
$(MAKE) -C ../../.. contrib/credential/osxkeychain/$@
> +install:
> + cd ../../..; make install-git-credential-osxkeychain
>
> clean:
> - $(RM) git-credential-osxkeychain git-credential-osxkeychain.o
> + cd ../../..; make clean-git-credential-osxkeychain
Likewise.
next prev parent reply other threads:[~2026-02-10 19:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 18:01 [PATCH] osxkeychain: define build targets in the top-level Makefile Koji Nakamaru via GitGitGadget
2026-02-10 19:50 ` Junio C Hamano [this message]
2026-02-10 23:16 ` Koji Nakamaru
2026-02-11 1:59 ` [PATCH v2] " Koji Nakamaru via GitGitGadget
2026-02-11 15:37 ` Junio C Hamano
2026-02-11 23:06 ` Koji Nakamaru
2026-02-16 23:45 ` D. Ben Knoble
2026-02-17 1:09 ` Koji Nakamaru
2026-02-17 13:10 ` D. Ben Knoble
2026-02-17 13:12 ` D. Ben Knoble
2026-02-17 18:05 ` Koji Nakamaru
2026-02-17 21:54 ` D. Ben Knoble
2026-02-18 4:06 ` Koji Nakamaru
2026-02-18 5:14 ` [PATCH v3] " Koji Nakamaru via GitGitGadget
2026-02-18 16:09 ` Kristoffer Haugsbakk
2026-02-18 19:11 ` Koji Nakamaru
2026-02-18 17:55 ` Junio C Hamano
2026-02-18 19:14 ` Koji Nakamaru
2026-02-19 15:25 ` Junio C Hamano
2026-02-20 1:39 ` [PATCH v4] " Koji Nakamaru via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl6cxtr7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=koji.nakamaru@gree.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.