From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: Usman Akinyemi <usmanakinyemi202@gmail.com>,
git@vger.kernel.org, chriscool@tuxfamily.org,
christian.couder@gmail.com, me@ttaylorr.com, ps@pks.im
Subject: Re: [PATCH V5 1/3] t/t1517: automate `git subcmd -h` tests outside a repository
Date: Sun, 03 Aug 2025 10:39:10 -0700 [thread overview]
Message-ID: <xmqqpldce24h.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CBCynikVcZq17SxOTfwuRMM86cv+BWQb0zZoOdMYX-72g@mail.gmail.com> (D. Ben Knoble's message of "Sun, 3 Aug 2025 10:52:56 -0400")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
> All fine, just leaving a note for myself ;) I didn't see any mention
> of the changed base in the cover letter, so I was confused. (Rebasing
> onto latest master makes sense to me, but I'm not sure what the list
> convention is).
Once you picked a base, usually it is a good idea to keep it, unless
making a trial merge of the resulting topic branch into 'master'
leaves conflicts that are not trivial. And I do appreciate your
noticing and mentioning that it is recommended to have a comment in
the cover letter (or a comment after the three-dash line if a single
patch topic) that the new iteration has been based on which commit.
Thanks.
next prev parent reply other threads:[~2025-08-03 17:39 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 21:41 [PATCH v2 0/7] move builtin help test to t1517 Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 1/7] t/t1517: move checkout-index -h " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 2/7] t/t1517: move for-each-ref " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 3/7] t/t1517: move ls-files " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 4/7] t/t1517: move pack-refs " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 5/7] t/t1517: move send-pack " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 6/7] t/t1517: move verify-commit " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 7/7] t/t1517: move verify-tag " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v2 0/7] move builtin help " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 1/7] t/t1517: move checkout-index -h " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 2/7] t/t1517: move for-each-ref " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 3/7] t/t1517: move ls-files " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 4/7] t/t1517: move pack-refs " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 5/7] t/t1517: move send-pack " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 6/7] t/t1517: move verify-commit " Usman Akinyemi
2025-07-07 16:12 ` Junio C Hamano
2025-07-10 22:59 ` Usman Akinyemi
2025-07-11 16:37 ` Junio C Hamano
2025-07-21 11:55 ` [PATCH v4 0/2] refactor t1517 to focus on help output outside a repository Usman Akinyemi
2025-07-21 11:55 ` [PATCH v4 1/2] t/t1517: automate `git subcmd -h` tests " Usman Akinyemi
2025-07-26 14:34 ` D. Ben Knoble
2025-07-26 21:53 ` Usman Akinyemi
2025-07-30 21:14 ` D. Ben Knoble
2025-07-28 15:08 ` Junio C Hamano
2025-08-02 19:56 ` D. Ben Knoble
2025-08-03 1:27 ` Usman Akinyemi
2025-07-26 14:37 ` D. Ben Knoble
2025-07-26 14:52 ` D. Ben Knoble
2025-07-26 21:51 ` Usman Akinyemi
2025-07-30 21:15 ` D. Ben Knoble
2025-07-28 15:09 ` Junio C Hamano
2025-08-26 15:57 ` Phillip Wood
2025-08-28 13:47 ` D. Ben Knoble
2025-08-29 13:05 ` Phillip Wood
2025-08-29 13:22 ` D. Ben Knoble
2025-08-29 16:31 ` Junio C Hamano
2025-08-30 3:49 ` Usman Akinyemi
2025-07-21 11:55 ` [PATCH v4 2/2] t5200: move `update-server-info -h` test from t1517 Usman Akinyemi
2025-07-26 16:02 ` D. Ben Knoble
2025-08-03 2:07 ` [PATCH V5 0/3] refactor t1517 to focus on help output outside a repository Usman Akinyemi
2025-08-03 2:07 ` [PATCH V5 1/3] t/t1517: automate `git subcmd -h` tests " Usman Akinyemi
2025-08-03 14:52 ` D. Ben Knoble
2025-08-03 17:39 ` Junio C Hamano [this message]
2025-08-06 7:20 ` Usman Akinyemi
2025-08-03 2:07 ` [PATCH V5 2/3] t5200: move `update-server-info -h` test from t1517 Usman Akinyemi
2025-08-03 2:07 ` [PATCH V5 3/3] t5304: move `prune " Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 0/3] refactor t1517 to focus on help output outside a repository Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 1/3] t/t1517: automate `git subcmd -h` tests " Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 2/3] t5200: move `update-server-info -h` test from t1517 Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 3/3] t5304: move `prune " Usman Akinyemi
2025-08-08 14:53 ` [PATCH v6 0/3] refactor t1517 to focus on help output outside a repository Junio C Hamano
2025-08-09 14:46 ` D. Ben Knoble
2025-07-06 21:50 ` [PATCH v3 7/7] t/t1517: move verify-tag -h test to t1517 Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpldce24h.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.