All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] http: do not ignore proxy path
Date: Wed, 31 Jul 2024 22:21:13 -0700	[thread overview]
Message-ID: <xmqqplqsyg1i.fsf@gitster.g> (raw)
In-Reply-To: <9ffa9bf5-f799-400f-5e45-ccbc5316ee42@alum.mit.edu> (Ryan Hendrickson's message of "Wed, 31 Jul 2024 23:44:08 -0400 (EDT)")

Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> writes:

>> We insist that it must be "localhost", so let's not do strcasecmp()
>> but just do strcmp().
>
> I don't see the wisdom of being more restrictive than curl is in this
> respect.

Ah, if curl is doing case insensitivity, then matching its behaviour
is perfectly fine.  I was just reacting to this message ...

> +	die("Invalid proxy URL '%s': host must be localhost if a path is present",

... that results when strcasecmp() does not like it.

Thanks.

  reply	other threads:[~2024-08-01  5:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-26 15:52 [PATCH] http: do not ignore proxy path Ryan Hendrickson via GitGitGadget
2024-07-26 16:29 ` Junio C Hamano
2024-07-26 17:12   ` Ryan Hendrickson
2024-07-26 17:45     ` Junio C Hamano
2024-07-26 21:11 ` Jeff King
2024-07-26 22:43   ` Ryan Hendrickson
2024-07-29 19:31     ` Jeff King
2024-07-27  6:44 ` [PATCH v2] " Ryan Hendrickson via GitGitGadget
2024-07-29 20:09   ` Jeff King
2024-07-31 15:33     ` Ryan Hendrickson
2024-07-31 16:01   ` [PATCH v3] " Ryan Hendrickson via GitGitGadget
2024-07-31 22:24     ` Junio C Hamano
2024-08-01  3:44       ` Ryan Hendrickson
2024-08-01  5:21         ` Junio C Hamano [this message]
2024-08-01  5:45       ` Jeff King
2024-08-01 14:40         ` Junio C Hamano
2024-08-01  5:22     ` [PATCH v4] " Ryan Hendrickson via GitGitGadget
2024-08-01  6:04       ` Jeff King
2024-08-01 17:04         ` Junio C Hamano
2024-08-02  5:20       ` [PATCH v5] " Ryan Hendrickson via GitGitGadget
2024-08-02 15:52         ` Junio C Hamano
2024-08-02 16:43           ` Ryan Hendrickson
2024-08-02 17:10             ` Junio C Hamano
2024-08-02 18:03               ` Ryan Hendrickson
2024-08-02 19:28                 ` Junio C Hamano
2024-08-02 19:39                   ` Ryan Hendrickson
2024-08-02 21:13                     ` Junio C Hamano
2024-08-02 21:26                       ` Ryan Hendrickson
2024-08-02 21:43                         ` Junio C Hamano
2024-08-02 21:47                         ` Junio C Hamano
2024-08-02 22:14                           ` Ryan Hendrickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqplqsyg1i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ryan.hendrickson@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.