From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <nasamuffin@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] usage: clarify --recurse-submodules as a boolean
Date: Mon, 10 Apr 2023 16:07:39 -0700 [thread overview]
Message-ID: <xmqqpm8bcp50.fsf@gitster.g> (raw)
In-Reply-To: <ZDCwT3mhaGHyydng@google.com> (Emily Shaffer's message of "Fri, 7 Apr 2023 17:07:43 -0700")
Emily Shaffer <nasamuffin@google.com> writes:
> It was 'git checkout', if you must know ;) and in such a hurry that I
> also neglected to s/three/four/g. Will fix it with the reroll.
You fixed three-or-four but not the missing comma in v2, it seems.
I locally touched it up while queuing v2, but ...
>> This however is a breaking change. Even though there is no hint
> ...
>> I am not
>> sure it is safe to change the behaviour right under them, like this
>> patch does, and I wonder if we should do this in two steps, with its
>> first step doing:
> ...
> I'd be happy to do so with a reroll, probably on Monday. It's true that
> while these are user-facing commands which we don't guarantee backwards
> compatibility for, there's not a reason to subject users to that kind of
> pain unnecessarily.
... I do not see how this part is addressed in v2. You got too
excited by the idea of how to replace the awful abuse of parse
options callback interface with a more focused setter function in
the API and forgot to do other changes you meant to or something?
Thanks.
next prev parent reply other threads:[~2023-04-10 23:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 22:18 [PATCH] usage: clarify --recurse-submodules as a boolean Emily Shaffer
2023-04-07 23:47 ` Junio C Hamano
2023-04-08 0:03 ` Junio C Hamano
2023-04-08 0:22 ` Emily Shaffer
2023-04-08 0:59 ` Junio C Hamano
2023-04-10 16:41 ` Emily Shaffer
2023-04-08 0:07 ` Emily Shaffer
2023-04-10 23:07 ` Junio C Hamano [this message]
2023-04-10 22:52 ` [PATCH v2] " Emily Shaffer
2023-04-10 23:10 ` Junio C Hamano
2023-05-05 17:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpm8bcp50.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nasamuffin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.