All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: darkdragon <darkdragon-001@web.de>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>, git@vger.kernel.org
Subject: Re: Install-prefix when building should not be hardcoded
Date: Wed, 05 Oct 2022 14:21:10 -0700	[thread overview]
Message-ID: <xmqqpmf6nf09.fsf@gitster.g> (raw)
In-Reply-To: <CAAOCJVAAwgECsJPfm7eHOMmKPewJzxHTKhjwacxPRYWJkSpX_g@mail.gmail.com> (darkdragon's message of "Wed, 5 Oct 2022 22:23:40 +0200")

darkdragon <darkdragon-001@web.de> writes:

> On Wed, Oct 5, 2022 at 9:34 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:
>>
>> > On 2022-10-04 09:38:24+0200, darkdragon <darkdragon-001@web.de> wrote:
>> >> Even though in Makefile, it is stated that git will figure out
>> >> gitexecdir at runtime based on the path to the executable, there are
>> >> many output files where $(prefix) will be hardcoded. Even git
>> >> --exec-path will print out $(compile_prefix)/libexec/git-core instead
>> >> of using run_prefix.
>> >
>> > I'm not sure about this part.
>>
>> Perhaps it is related to the use of RUNTIME_PREFIX (which I don't
>> use myself)?
>
> This seems to do the trick! Thanks a lot!

I guess somebody needs to send a patch to the Makefile to clarify
the comment that led us confused in this thread.  Volunteers?

Thanks.

  reply	other threads:[~2022-10-05 21:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04  7:38 Install-prefix when building should not be hardcoded darkdragon
2022-10-04  7:57 ` Đoàn Trần Công Danh
2022-10-04  8:40   ` darkdragon
2022-10-05 19:34   ` Junio C Hamano
2022-10-05 20:23     ` darkdragon
2022-10-05 21:21       ` Junio C Hamano [this message]
2022-10-06  1:32         ` [PATCH] Makefile: clarify runtime relative gitexecdir Đoàn Trần Công Danh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpmf6nf09.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=darkdragon-001@web.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.