From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Emily Shaffer <emilyshaffer@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] config: let feature.experimental imply gc.cruftPacks=true
Date: Thu, 04 Aug 2022 09:10:47 -0700 [thread overview]
Message-ID: <xmqqpmhg6lbs.fsf@gitster.g> (raw)
In-Reply-To: <6803b725-526e-a1c8-f15c-a9ed4a144d4c@github.com> (Derrick Stolee's message of "Thu, 4 Aug 2022 09:05:43 -0400")
Derrick Stolee <derrickstolee@github.com> writes:
> On 8/3/2022 4:57 PM, Emily Shaffer wrote:
>
>> + /* feature.experimental implies gc.cruftPacks=true */
>> + git_config_get_bool("feature.experimental", &experimental);
>> + if (experimental)
>> + cruft_packs = 1;
>> +
>
> This should be grouped into prepare_repo_settings() in repo-settings.c
> so we have a single place to see what is updated by feature.experimental.
Excellent. I forgot about that. Thanks.
prev parent reply other threads:[~2022-08-04 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 20:57 [PATCH 0/2] let feature.experimental imply gc.cruftPacks=true Emily Shaffer
2022-08-03 20:57 ` [PATCH 1/2] gc: add tests for --cruft and friends Emily Shaffer
2022-08-03 21:56 ` Junio C Hamano
2022-08-04 7:48 ` Ævar Arnfjörð Bjarmason
2022-08-04 16:09 ` Junio C Hamano
2022-08-03 20:57 ` [PATCH 2/2] config: let feature.experimental imply gc.cruftPacks=true Emily Shaffer
2022-08-03 22:05 ` Junio C Hamano
2022-08-04 13:05 ` Derrick Stolee
2022-08-04 16:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmhg6lbs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.