From: Junio C Hamano <gitster@pobox.com>
To: Fabian Stelzer <fs@gigacodes.de>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Adam Dinwoodie" <adam@dinwoodie.org>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2 2/2] test-lib: introduce required prereq for test runs
Date: Thu, 18 Nov 2021 15:42:16 -0800 [thread overview]
Message-ID: <xmqqpmqxuj3b.fsf@gitster.g> (raw)
In-Reply-To: <20211117090410.8013-3-fs@gigacodes.de> (Fabian Stelzer's message of "Wed, 17 Nov 2021 10:04:10 +0100")
Fabian Stelzer <fs@gigacodes.de> writes:
> + # Abort if this prereq was marked as required
> + if test -n $GIT_TEST_REQUIRE_PREREQ
If GIT_TEST_REQUIRE_PREREQ is an empty string, this will ask
test -n
and "test" will say "yes" (because "-n" is not an empty string).
Let's surround it with a pair of double-quotes.
> + then
> + case ",$GIT_TEST_REQUIRE_PREREQ," in
> + *,$prerequisite,*)
> + error "required prereq $prerequisite failed"
> + ;;
> + esac
> + fi
> +
> if test -z "$missing_prereq"
> then
> missing_prereq=$prerequisite
next prev parent reply other threads:[~2021-11-18 23:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 9:04 [PATCH v2 0/2] test-lib: improve missing prereq handling Fabian Stelzer
2021-11-17 9:04 ` [PATCH v2 1/2] test-lib: show missing prereq summary Fabian Stelzer
2021-11-17 9:04 ` [PATCH v2 2/2] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-18 23:42 ` Junio C Hamano [this message]
2021-11-19 9:07 ` Fabian Stelzer
2021-11-19 11:13 ` Ævar Arnfjörð Bjarmason
2021-11-19 13:48 ` Fabian Stelzer
2021-11-19 14:09 ` Fabian Stelzer
2021-11-19 14:26 ` Ævar Arnfjörð Bjarmason
2021-11-19 15:40 ` Fabian Stelzer
2021-11-19 16:37 ` Ævar Arnfjörð Bjarmason
2021-11-20 15:03 ` [PATCH v3 0/3] test-lib: improve missing prereq handling Fabian Stelzer
2021-11-20 15:03 ` [PATCH v3 1/3] test-lib: show missing prereq summary Fabian Stelzer
2021-11-20 15:04 ` [PATCH v3 2/3] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-20 15:04 ` [PATCH v3 3/3] test-lib: make BAIL_OUT() work in tests and prereq Fabian Stelzer
2021-11-22 11:52 ` Ævar Arnfjörð Bjarmason
2021-11-22 17:05 ` Junio C Hamano
2021-11-26 9:55 ` Fabian Stelzer
2021-11-26 21:02 ` Junio C Hamano
2021-11-27 12:47 ` Fabian Stelzer
2021-11-28 23:38 ` Junio C Hamano
2021-11-30 14:38 ` Fabian Stelzer
2021-11-30 14:59 ` Ævar Arnfjörð Bjarmason
2021-12-01 8:53 ` [PATCH v4 0/3] test-lib: improve missing prereq handling Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 1/3] test-lib: show missing prereq summary Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 2/3] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-12-01 8:53 ` [PATCH v4 3/3] test-lib: make BAIL_OUT() work in tests and prereq Fabian Stelzer
2021-12-01 23:13 ` Junio C Hamano
2021-12-01 21:05 ` [PATCH v4 0/3] test-lib: improve missing prereq handling Adam Dinwoodie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmqxuj3b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.