All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
	"Jeff King" <peff@peff.net>
Subject: Re: [PATCH] archive: add test testing MIME for created archive through compression filter
Date: Mon, 11 Oct 2021 08:48:53 -0700	[thread overview]
Message-ID: <xmqqpmsbd0ka.fsf@gitster.g> (raw)
In-Reply-To: <20211011112712.475306-1-bagasdotme@gmail.com> (Bagas Sanjaya's message of "Mon, 11 Oct 2021 18:27:13 +0700")

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> +	cat >expect <<EOF &&
> +HEAD.tar.bz2: application/x-bzip2; charset=binary
> +HEAD.tar.gz:  application/gzip; charset=binary
> +HEAD.tar.xz:  application/x-xz; charset=binary
> +EOF

Use <<-EOF and you can align here-document to the script.

> +	file -i HEAD.tar.bz2 HEAD.tar.gz HEAD.tar.xz 2>/dev/null >actual &&

This looks super un-portable.

  https://pubs.opengroup.org/onlinepubs/9699919799/utilities/file.html



  reply	other threads:[~2021-10-11 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 11:27 [PATCH] archive: add test testing MIME for created archive through compression filter Bagas Sanjaya
2021-10-11 15:48 ` Junio C Hamano [this message]
2021-10-11 15:53 ` Junio C Hamano
2021-10-11 16:07   ` Jeff King
2021-10-12  3:14   ` Bagas Sanjaya
2021-10-12 19:15     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpmsbd0ka.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.