From: Junio C Hamano <gitster@pobox.com>
To: Igor Djordjevic <igor.d.djordjevic@gmail.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>,
"Leah Neukirchen" <leah@vuxu.org>
Subject: Re: [PATCH] help: colorize man pages
Date: Sat, 22 May 2021 08:32:19 +0900 [thread overview]
Message-ID: <xmqqpmxjr7cs.fsf@gitster.g> (raw)
In-Reply-To: <8811383b-d5f1-2b06-8ac7-47bbc5fc9d20@gmail.com> (Igor Djordjevic's message of "Fri, 21 May 2021 21:48:17 +0200")
Igor Djordjevic <igor.d.djordjevic@gmail.com> writes:
> Hi all,
>
> If I may, NO_COLOR approach seems to be rather straightforward to me,
> as per description on their homepage[1] - make all software supporting
> it behave as colors are an opt-in feature, thus disabled by default.
Yes, that is correct and this was discussed already in detail a few
days ago. You can start from here:
https://lore.kernel.org/git/YKRSlFcFAcHcR3uY@camp.crustytoothpaste.net/
and read two or three messages.
Note that you probably want to take generic NO_COLOR support
(i.e. teaching the "now we know the user wants the 'default'
behaviour by not having an explicit 'yes/no'; do we want to color
the output?" helper function to pay attention to the environment
variable) as taken by somebody already:
https://lore.kernel.org/git/YKcFrbuuJrWAxXgm@camp.crustytoothpaste.net/
Thanks.
next prev parent reply other threads:[~2021-05-21 23:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 1:01 [PATCH] help: colorize man pages Felipe Contreras
2021-05-18 1:19 ` brian m. carlson
2021-05-18 3:22 ` Felipe Contreras
2021-05-18 23:49 ` brian m. carlson
2021-05-19 1:08 ` Junio C Hamano
2021-05-19 2:07 ` brian m. carlson
2021-05-19 6:09 ` Junio C Hamano
2021-05-19 8:41 ` Ævar Arnfjörð Bjarmason
2021-05-19 10:36 ` Felipe Contreras
2021-05-21 0:58 ` brian m. carlson
2021-05-21 18:09 ` Felipe Contreras
2021-05-21 19:48 ` Igor Djordjevic
2021-05-21 21:20 ` Felipe Contreras
2021-05-21 22:10 ` Igor Djordjevic
2021-05-21 23:04 ` Felipe Contreras
2021-05-22 18:38 ` Igor Djordjevic
2021-05-22 21:48 ` Felipe Contreras
2021-05-23 11:25 ` Igor Djordjevic
2021-05-23 14:48 ` Felipe Contreras
2021-05-21 22:47 ` Igor Djordjevic
2021-05-21 23:32 ` Junio C Hamano [this message]
2021-05-19 9:26 ` Ævar Arnfjörð Bjarmason
2021-05-19 10:10 ` Jeff King
2021-05-19 11:45 ` Felipe Contreras
2021-05-19 11:19 ` Felipe Contreras
2021-05-19 12:21 ` Felipe Contreras
2021-05-20 1:55 ` brian m. carlson
2021-05-20 2:23 ` Junio C Hamano
2021-05-20 3:05 ` Felipe Contreras
2021-05-20 3:28 ` Junio C Hamano
2021-05-20 3:48 ` Felipe Contreras
2021-05-20 2:45 ` Felipe Contreras
2021-05-19 10:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmxjr7cs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=igor.d.djordjevic@gmail.com \
--cc=leah@vuxu.org \
--cc=rsbecker@nexbridge.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.