From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Oct 2020, #02; Fri, 9)
Date: Fri, 09 Oct 2020 09:28:10 -0700 [thread overview]
Message-ID: <xmqqpn5rtld1.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <512a3dc5-4937-8679-c4c8-5144ac50450b@gmail.com> (Derrick Stolee's message of "Fri, 9 Oct 2020 12:15:31 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> As for discarding them all: we would need to add code to "reparse"
> a commit from the object database. Perhaps that is doable, but we
> have so far not removed data from a parsed 'struct commit'. This
> is probably the easiest way forward to guarantee correct data here.
Oh, no, by "discarding" I just meant to blow away suspect on-disk
files and recompute them from scratch. I didn't have anything
clever like correcting in-core data structure by parsing the commits
and updating.
> Again, let's find a way to test this before committing.
Yes, that is sensible. After all this is not a recent regression.
next prev parent reply other threads:[~2020-10-09 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:59 What's cooking in git.git (Oct 2020, #02; Fri, 9) Junio C Hamano
2020-10-09 16:15 ` Derrick Stolee
2020-10-09 16:28 ` Junio C Hamano [this message]
2020-10-09 16:31 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpn5rtld1.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.