From: Junio C Hamano <gitster@pobox.com>
To: "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Sean Estabrooks <seanlkml@sympatico.ca>,
Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH] git.txt: correct stale 'GIT_EXTERNAL_DIFF' description
Date: Tue, 01 Sep 2020 12:16:22 -0700 [thread overview]
Message-ID: <xmqqpn75cnp5.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.718.git.1598966412371.gitgitgadget@gmail.com> (Philippe Blain via GitGitGadget's message of "Tue, 01 Sep 2020 13:20:12 +0000")
"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> diff --git a/Documentation/diff-generate-patch.txt b/Documentation/diff-generate-patch.txt
> index e8ed6470fb..b10ff4caa6 100644
> --- a/Documentation/diff-generate-patch.txt
> +++ b/Documentation/diff-generate-patch.txt
> @@ -10,7 +10,8 @@ linkgit:git-diff-tree[1], or
> linkgit:git-diff-files[1]
> with the `-p` option produces patch text.
> You can customize the creation of patch text via the
> -`GIT_EXTERNAL_DIFF` and the `GIT_DIFF_OPTS` environment variables.
> +`GIT_EXTERNAL_DIFF` and the `GIT_DIFF_OPTS` environment variables
> +(see linkgit:git[1]).
>
> What the -p option produces is slightly different from the traditional
> diff format:
> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index 2fc92586b5..98bdf0983c 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -551,8 +551,9 @@ Git Diffs
>
> `GIT_EXTERNAL_DIFF`::
> When the environment variable `GIT_EXTERNAL_DIFF` is set, the
> - program named by it is called, instead of the diff invocation
> - described above. For a path that is added, removed, or modified,
> + program named by it is called to generate diffs, and Git
> + does not use its builtin diff machinery.
> + For a path that is added, removed, or modified,
> `GIT_EXTERNAL_DIFF` is called with 7 parameters:
Excellent. Thanks. Will queue.
prev parent reply other threads:[~2020-09-01 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 13:20 [PATCH] git.txt: correct stale 'GIT_EXTERNAL_DIFF' description Philippe Blain via GitGitGadget
2020-09-01 19:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpn75cnp5.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=seanlkml@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.