From: Junio C Hamano <gitster@pobox.com>
To: Laurent Arnoud <laurent@spkdev.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] format-patch: generate valid patch with diff.noprefix config
Date: Tue, 02 Jun 2020 14:12:37 -0700 [thread overview]
Message-ID: <xmqqpnahrx2y.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200602204924.GA1853335@spk-laptop> (Laurent Arnoud's message of "Tue, 2 Jun 2020 22:49:24 +0200")
Laurent Arnoud <laurent@spkdev.net> writes:
> With diff.noprefix enabled the patch generated with format-patch does not
> include prefix a/ and b/ so not applicable with `git am`.
Some projects (not this one) do not want to see a/ and b/ prefix in
their patches, and noprefix is an option for those who needs to give
patches to such projects. As "am" can be told with -p<num> to accept
such a patch just fine, I do not think this change is appropriate.
> Solution is to force a_prefix and b_prefix on diffopt.
Sorry, I do not think there is any problem to be solved here ;-)
next prev parent reply other threads:[~2020-06-02 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 20:49 [PATCH] format-patch: generate valid patch with diff.noprefix config Laurent Arnoud
2020-06-02 21:12 ` Junio C Hamano [this message]
2020-06-02 21:33 ` Laurent Arnoud
2020-06-02 22:09 ` Junio C Hamano
2020-06-04 19:32 ` Laurent Arnoud
2020-06-04 20:18 ` Junio C Hamano
2020-06-04 23:26 ` Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnahrx2y.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=laurent@spkdev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.