From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, tboegi@web.de, e@80x24.org,
ttaylorr@github.com, peartben@gmail.com
Subject: Re: [PATCH v7 3/6] t0021: write "OUT <size>" only on success
Date: Tue, 27 Jun 2017 14:26:22 -0700 [thread overview]
Message-ID: <xmqqpodpyvep.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <BEB23654-54FB-40B0-8C7B-E70D1E5BBCF7@gmail.com> (Lars Schneider's message of "Tue, 27 Jun 2017 22:51:46 +0200")
Lars Schneider <larsxschneider@gmail.com> writes:
> Correct! Sorry for the confusion. How about this?
>
> "rot13-filter.pl" always writes "OUT <size>" to the debug log at the end
> of a response.
>
> This works perfectly for the existing responses "abort", "error", and
> "success". A new response "delayed", that will be introduced in a
> subsequent patch, accepts the input without giving the filtered result
> right away. At this point we cannot know the size of the response.
> Therefore, we do not write "OUT <size>" for "delayed" responses.
>
> To simplify the code we do not write "OUT <size>" for "abort" and
> "error" responses either as their size is always zero.
That unconfuses me tremendously.
Unless there are other issues in v7 (which I am not aware of but
there may be somebody else slow responding), I plan to amend the log
message with the above, so no need to resend.
Thanks.
next prev parent reply other threads:[~2017-06-27 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 12:10 [PATCH v7 0/6] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-06-27 12:10 ` [PATCH v7 1/6] t0021: keep filter log files on comparison Lars Schneider
2017-06-27 12:10 ` [PATCH v7 2/6] t0021: make debug log file name configurable Lars Schneider
2017-06-27 12:10 ` [PATCH v7 3/6] t0021: write "OUT <size>" only on success Lars Schneider
2017-06-27 18:44 ` Junio C Hamano
2017-06-27 20:51 ` Lars Schneider
2017-06-27 21:26 ` Junio C Hamano [this message]
2017-06-27 12:10 ` [PATCH v7 4/6] convert: put the flags field before the flag itself for consistent style Lars Schneider
2017-06-27 12:10 ` [PATCH v7 5/6] convert: move multiple file filter error handling to separate function Lars Schneider
2017-06-27 12:10 ` [PATCH v7 6/6] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-06-27 19:00 ` Junio C Hamano
2017-06-27 20:34 ` Lars Schneider
2017-06-27 21:30 ` Junio C Hamano
2017-06-27 21:58 ` Lars Schneider
2017-06-27 21:49 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpodpyvep.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
--cc=tboegi@web.de \
--cc=ttaylorr@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.