From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twosigma.com>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH v2] upload-pack: Optionally allow fetching any sha1
Date: Sat, 12 Nov 2016 17:23:27 -0800 [thread overview]
Message-ID: <xmqqpom0yxyo.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1478885028-30357-1-git-send-email-dturner@twosigma.com> (David Turner's message of "Fri, 11 Nov 2016 12:23:48 -0500")
David Turner <dturner@twosigma.com> writes:
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index 43665ab..8d3db40 100755
It seems that I haven't heard of 43665ab.
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -306,6 +306,28 @@ test_expect_success 'test allowreachablesha1inwant with unreachable' '
> test_must_fail git -C test_reachable.git fetch origin "$(git rev-parse HEAD)"
> '
Specifically, the above seems to be missing in my tree.
Perhaps you noticed the lack of test for allowReachableSHA1InWant
and added one, but forgot to send it out, while building this patch
on top?
> +uploadpack.allowAnySHA1InWant::
> + Allow `upload-pack` to accept a fetch request that asks for any
> + object at all.
> + Defaults to `false`.
next prev parent reply other threads:[~2016-11-13 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 17:23 [PATCH v2] upload-pack: Optionally allow fetching any sha1 David Turner
2016-11-13 1:23 ` Junio C Hamano [this message]
2016-11-14 16:02 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpom0yxyo.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.