From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, Ramsay Jones <ramsay@ramsayjones.plus.com>,
Erik Faye-Lund <kusmabite@googlemail.com>,
Pat Thoyts <patthoyts@users.sourceforge.net>
Subject: Re: [PATCH v2 0/2] Support marking .git/ (or all files) as hidden on Windows
Date: Mon, 09 May 2016 10:01:59 -0700 [thread overview]
Message-ID: <xmqqposvw4fs.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <cover.1462603453.git.johannes.schindelin@gmx.de> (Johannes Schindelin's message of "Sat, 7 May 2016 08:44:42 +0200 (CEST)")
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> This is a heavily version of patches we carried in Git for Windows for
> way too long without submitting them upstream.
>
> In this iteration, I also claim authorship for the patch because by now
> Kusma's changes were so contorted and mutilated beyond recognition by me
> that I do not want anybody to blame him for my sins.
OK, so what do you want me to do with this "heavily modified
version"? Earlier you responded:
> I have a huge preference for a code that has been production for
> years over a new code that would cook at most two weeks in 'next'.
I agree. However, it does not fill me with confidence that we did not
catch those two bugs earlier. Even one round of reviews (including a
partial rewrite) was better than all that time since the regressions
were introduced.
So do we want to follow the regular "a few days in 'pu' in case
somebody finds 'oops this trivial change is needed', a week or two
in 'next' for simmering as everybody else, and finally down to
'master'" schedule?
next prev parent reply other threads:[~2016-05-09 17:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 14:40 [PATCH] mingw: introduce the 'core.hideDotFiles' setting Johannes Schindelin
2016-05-04 16:18 ` Ramsay Jones
2016-05-06 12:06 ` Johannes Schindelin
2016-05-04 19:06 ` Junio C Hamano
2016-05-06 15:19 ` Johannes Schindelin
2016-05-06 16:34 ` Junio C Hamano
2016-05-06 17:17 ` Junio C Hamano
2016-05-07 6:01 ` Johannes Schindelin
2016-05-07 6:44 ` Johannes Schindelin
2016-05-07 6:44 ` [PATCH v2 0/2] Support marking .git/ (or all files) as hidden on Windows Johannes Schindelin
2016-05-07 6:45 ` [PATCH v2 1/2] mingw: introduce the 'core.hideDotFiles' setting Johannes Schindelin
2016-05-09 17:23 ` Junio C Hamano
2016-05-10 11:58 ` Johannes Schindelin
2016-05-10 17:19 ` Junio C Hamano
2016-05-11 8:40 ` Johannes Schindelin
2016-05-07 6:45 ` [PATCH v2 2/2] mingw: remove unnecessary definition Johannes Schindelin
2016-05-09 17:01 ` Junio C Hamano [this message]
2016-05-10 8:41 ` [PATCH v2 0/2] Support marking .git/ (or all files) as hidden on Windows Johannes Schindelin
2016-05-10 17:22 ` Junio C Hamano
2016-05-11 8:34 ` Johannes Schindelin
2016-05-10 11:59 ` [PATCH v3 " Johannes Schindelin
2016-05-10 11:59 ` [PATCH v3 1/2] mingw: introduce the 'core.hideDotFiles' setting Johannes Schindelin
2016-05-10 11:59 ` [PATCH v3 2/2] mingw: remove unnecessary definition Johannes Schindelin
2016-05-11 8:40 ` [PATCH v4 0/2] Support marking .git/ (or all files) as hidden on Windows Johannes Schindelin
2016-05-11 8:43 ` Johannes Schindelin
2016-05-11 8:43 ` [PATCH v4 1/2] mingw: introduce the 'core.hideDotFiles' setting Johannes Schindelin
2016-05-11 8:43 ` [PATCH v4 2/2] mingw: remove unnecessary definition Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqposvw4fs.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kusmabite@googlemail.com \
--cc=patthoyts@users.sourceforge.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.