From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v2 0/2] git-p4: fix AsciiDoc formatting
Date: Mon, 21 Mar 2016 10:53:42 -0700 [thread overview]
Message-ID: <xmqqpounn2e1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1458499161-61642-1-git-send-email-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Sun, 20 Mar 2016 19:39:19 +0100")
larsxschneider@gmail.com writes:
> From: Lars Schneider <larsxschneider@gmail.com>
>
> diff to v1:
> * reference external pages similar to git-bisect-lk2009 (thanks Luke)
> * fix quotation marks (you can see the error here:
> https://git-scm.com/docs/git-p4/2.7.4 ... search for cp1252 )
>
> Thanks,
> Lars
>
>
> Lars Schneider (2):
> Documentation: fix git-p4 AsciiDoc formatting
> Documentation: use ASCII quotation marks in git-p4
>
> Documentation/git-p4.txt | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Hmph, this seems to break my build.
xmlto: /home/gitster/w/git.git/Documentation/git-p4.xml does not validate (status 3)
xmlto: Fix document syntax or use --skip-validation option
/home/gitster/w/git.git/Documentation/git-p4.xml:812: element xref: validity error : Syntax of value for attribute linkend of xref is not valid
/home/gitster/w/git.git/Documentation/git-p4.xml:1077: element anchor: validity error : Syntax of value for attribute id of anchor is not valid
Document /home/gitster/w/git.git/Documentation/git-p4.xml does not validate
On line #812 of the generated file I see this:
Only Git LFS <xref linkend="1"/> is implemented right now. Download
And line #1077 I see this:
<anchor id="1" xreflabel="[1]"/>[1] <ulink url="https://git-lfs.github.com/">Git LFS - An open source Git extension for versioning large files</ulink>
It could be that mimicking git-bisect-lk2009 that never is formatted
as manpage is a bad idea to begin with?
$ xmlto --version
xmlto version 0.0.25
prev parent reply other threads:[~2016-03-21 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 18:39 [PATCH v2 0/2] git-p4: fix AsciiDoc formatting larsxschneider
2016-03-20 18:39 ` [PATCH v2 1/2] Documentation: fix git-p4 " larsxschneider
2016-03-20 18:39 ` [PATCH v2 2/2] Documentation: use ASCII quotation marks in git-p4 larsxschneider
2016-03-21 17:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpounn2e1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.